You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Hasan Diwan (Jira)" <ji...@apache.org> on 2020/12/02 06:20:00 UTC
[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum
of U1 and U2
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242075#comment-17242075 ]
Hasan Diwan commented on MATH-1453:
-----------------------------------
The attached patch:
1) alters the return type of mannWhitneyU to a java.util.Map with two keys:
a) "minimum", which does what Nikos Katsipoulakis calls for.
b) "maximum", which maintains current behaviour.
2. Updates the test to reflect the changed return value and make them pass.
I look forward to seeing this closed in short order. [^1453.diff]
> Mann-Whitney U Test returns maximum of U1 and U2
> ------------------------------------------------
>
> Key: MATH-1453
> URL: https://issues.apache.org/jira/browse/MATH-1453
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.6.1
> Reporter: Nikos Katsipoulakis
> Priority: Critical
> Attachments: 1453.diff
>
>
> Currently, I need to use Mann-Whitney U Test and I figured out that Apache Commons Math has it implemented. After consulting the [Wiki|https://en.wikipedia.org/wiki/Mann%E2%80%93Whitney_U_test] presented in the Java Doc, it indicates that the U statistic of this test is the minimum among U1 and U2. However, when I look into Apache Commons Math {{MannWhitneyUTest.mannWhitneyU()}} method, it returns the maximum of U1 and U2. In fact, the code of this method is the following:
>
> {code:java}
> public double mannWhitneyU(double[] x, double[] y) throws NullArgumentException, NoDataException {
> this.ensureDataConformance(x, y);
> double[] z = this.concatenateSamples(x, y);
> double[] ranks = this.naturalRanking.rank(z);
> double sumRankX = 0.0D;
> for(int i = 0; i < x.length; ++i) {
> sumRankX += ranks[i];
> }
> double U1 = sumRankX - (double)((long)x.length * (long)(x.length + 1) / 2L);
> double U2 = (double)((long)x.length * (long)y.length) - U1;
> return FastMath.max(U1, U2);
> }
> {code}
> Also, in the Java Doc it is stated that the maximum value of U1 and U2 is returned.
>
> My question is why Apache Commons returns the maximum of those two values, whereas all other sources I found online indicate returning the minimum? If this is not wrong, then shouldn't the Java Doc be updated to include a source that justifies that the maximum U should be returned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)