You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/28 16:55:39 UTC
[GitHub] [skywalking-java] BFergerson opened a new pull request #113: Add witness classes
BFergerson opened a new pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113
Added witness classes to graphql and vertx-core-3.x plugins.
`graphql.execution.ExecutionPath` which is available for provided plugins:
https://github.com/graphql-java/graphql-java/blob/v8.0/src/main/java/graphql/execution/ExecutionPath.java
https://github.com/graphql-java/graphql-java/blob/v9.0/src/main/java/graphql/execution/ExecutionPath.java
https://github.com/graphql-java/graphql-java/blob/v12.0/src/main/java/graphql/execution/ExecutionPath.java
Is not available for v16+:
https://github.com/graphql-java/graphql-java/blob/v16.0/src/main/java/graphql/execution/ExecutionPath.java
---
`io.vertx.core.http.impl.WebSocketFrameFactoryImpl` which is available for beginning to end of 3.x
https://github.com/eclipse-vertx/vert.x/blob/3.0.0/src/main/java/io/vertx/core/http/impl/WebSocketFrameFactoryImpl.java
https://github.com/eclipse-vertx/vert.x/blob/3.9.12/src/main/java/io/vertx/core/http/impl/WebSocketFrameFactoryImpl.java
Is not available for 4.x:
https://github.com/eclipse-vertx/vert.x/blob/4.0.0/src/main/java/io/vertx/core/http/impl/WebSocketFrameFactoryImpl.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055224509
> I'm not too sure what your first question means. If you're asking if they will make future versions fail, I would say they are already doing that. I'm using Vert.x 4.x and Graphql 17.0 and getting exceptions whenever I use them.
Yes, that was my question, and after I checked the codes in my morning, I had known this breaking exists already. Then I merged this PR before you wake up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #113: Add witness classes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1054808496
Are these plugins will throw exception or leak tracecontext for higher versions? Such as target classes still have the same method signature but very difficult logic inside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] BFergerson edited a comment on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
BFergerson edited a comment on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055222702
Yes, they cause NPE/NoClassDefFound errors with future versions. That's why I added witness classes. I'm using Vert.x 4.x and Graphql 17.0 and getting tons of exceptions.
For your second question, I'll be adding support for Vert.x 4.x. I'm not familiar with the Graphql library/plugin, but I'll see if I can add that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] BFergerson commented on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
BFergerson commented on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055226017
I haven't had my coffee yet. It took me another read before I knew what you asked lol. Thanks for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] BFergerson edited a comment on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
BFergerson edited a comment on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055222702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] BFergerson commented on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
BFergerson commented on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055222702
I'm not too sure what your first question means. If you're asking if they will make future versions fail, I would say they are already doing that. I'm using Vert.x 4.x and Graphql 17.0 and getting exceptions whenever I use them.
For your second question, I'll be adding support for Vert.x 4.x. I'm not very familiar with the Graphql library/plugin, but I'll see if I can add that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #113: Add witness classes to graphql and vertx-core-3.x plugins
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #113:
URL: https://github.com/apache/skywalking-java/pull/113#issuecomment-1055230010
> I haven't had my coffee yet. It took me another read before I knew what you asked lol. Thanks for merging
:P Go for your coffee, I am feeling I had too many today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org