You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/04/21 02:53:51 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Alonexc opened a new issue, #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   Do some optimization.
   
   ### Describe the solution you'd like
   
   located in:eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/PropertyConst.java
   
   ![image](https://user-images.githubusercontent.com/91315508/164358571-c2fad178-0008-4e19-9752-011350890150.png)
   This class is not in use and it is recommended to delete it.
   
   located in:eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/producer
   ![image](https://user-images.githubusercontent.com/91315508/164359608-1457c060-a70b-467a-b325-68ef8394c47f.png)
   ![image](https://user-images.githubusercontent.com/91315508/164359635-8da3ceac-d072-4d7c-8231-e8089c8f84b4.png)
   ![image](https://user-images.githubusercontent.com/91315508/164359653-b9df63e1-84fd-4b69-8f16-1b14155832ac.png)
   
   The constant classes in the CloudDeventProducer, EventMeshMessageProducer, and OpenMessageProducer classes in this package suggest extracting a constant class and putting it there.in eventmesh - sdk - java/src/main/Java/org/apache/eventmesh/client/http directory and create a common directory will be the constant class into it,change the PROTOCOL_TYPE to CE_PROTOCOL, EM_MESSAGE_PROTOCOL, and OP_MESSAGE_PROTOCOL, respectively.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 commented on issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843#issuecomment-1120967963

   @Markliniubility How is the progress of this issue ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 commented on issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843#issuecomment-1109409499

   > Hi,
   > 
   > I would like to work on this issue. Thanks!
   
   welcome @Markliniubility 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Markliniubility commented on issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
Markliniubility commented on issue #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843#issuecomment-1109408830

   Hi,
   
   I would like to work on this issue. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Markliniubility commented on issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
Markliniubility commented on issue #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843#issuecomment-1121716177

   > @Markliniubility How is the progress of this issue ?
   
   Sorry about the delay! I just submitted the PR for it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 closed issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module
URL: https://github.com/apache/incubator-eventmesh/issues/843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xiaoyang-sde commented on issue #843: [Enhancement] Some optimizations to the eventmesh-sdk module

Posted by GitBox <gi...@apache.org>.
xiaoyang-sde commented on issue #843:
URL: https://github.com/apache/incubator-eventmesh/issues/843#issuecomment-1109410178

   > Hi,
   > 
   > I would like to work on this issue. Thanks!
   
   Welcome to the EventMesh community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org