You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by om...@apache.org on 2011/03/04 05:15:22 UTC
svn commit: r1077441 - in
/hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop:
ipc/Server.java ipc/metrics/RpcMetrics.java
security/UserGroupInformation.java
Author: omalley
Date: Fri Mar 4 04:15:22 2011
New Revision: 1077441
URL: http://svn.apache.org/viewvc?rev=1077441&view=rev
Log:
commit 7a897ca2f283f68742c759b1918cd6cb7dfe3152
Author: Boris Shkolnik <bo...@yahoo-inc.com>
Date: Wed May 5 09:15:13 2010 -0700
HADOOP:6745 from https://issues.apache.org/jira/secure/attachment/12443726/HADOOP-6745-BP20-2.patch
+++ b/YAHOO-CHANGES.txt
+ HADOOP-6745. adding some java doc to Server.RpcMetrics, UGI (boryas)
+
Modified:
hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/Server.java
hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/metrics/RpcMetrics.java
hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/security/UserGroupInformation.java
Modified: hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/Server.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/Server.java?rev=1077441&r1=1077440&r2=1077441&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/Server.java (original)
+++ hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/Server.java Fri Mar 4 04:15:22 2011
@@ -238,7 +238,10 @@ public abstract class Server {
}
}
- /*Returns a handle to the rpcMetrics (required in tests)*/
+ /**
+ * Returns a handle to the rpcMetrics (required in tests)
+ * @return rpc metrics
+ */
public RpcMetrics getRpcMetrics() {
return rpcMetrics;
}
Modified: hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/metrics/RpcMetrics.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/metrics/RpcMetrics.java?rev=1077441&r1=1077440&r2=1077441&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/metrics/RpcMetrics.java (original)
+++ hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/ipc/metrics/RpcMetrics.java Fri Mar 4 04:15:22 2011
@@ -74,26 +74,57 @@ public class RpcMetrics implements Updat
* -they can also be read directly - e.g. JMX does this.
*/
+ /**
+ * metrics - number of bytes received
+ */
public final MetricsTimeVaryingLong receivedBytes =
new MetricsTimeVaryingLong("ReceivedBytes", registry);
+ /**
+ * metrics - number of bytes sent
+ */
public final MetricsTimeVaryingLong sentBytes =
new MetricsTimeVaryingLong("SentBytes", registry);
+ /**
+ * metrics - rpc queue time
+ */
public final MetricsTimeVaryingRate rpcQueueTime =
new MetricsTimeVaryingRate("RpcQueueTime", registry);
- public MetricsTimeVaryingRate rpcProcessingTime =
+ /**
+ * metrics - rpc processing time
+ */
+ public final MetricsTimeVaryingRate rpcProcessingTime =
new MetricsTimeVaryingRate("RpcProcessingTime", registry);
+ /**
+ * metrics - number of open connections
+ */
public final MetricsIntValue numOpenConnections =
new MetricsIntValue("NumOpenConnections", registry);
+ /**
+ * metrics - length of the queue
+ */
public final MetricsIntValue callQueueLen =
new MetricsIntValue("callQueueLen", registry);
+ /**
+ * metrics - number of failed authentications
+ */
public final MetricsTimeVaryingInt authenticationFailures =
new MetricsTimeVaryingInt("rpcAuthenticationFailures", registry);
+ /**
+ * metrics - number of successful authentications
+ */
public final MetricsTimeVaryingInt authenticationSuccesses =
new MetricsTimeVaryingInt("rpcAuthenticationSuccesses", registry);
+ /**
+ * metrics - number of failed authorizations
+ */
public final MetricsTimeVaryingInt authorizationFailures =
new MetricsTimeVaryingInt("rpcAuthorizationFailures", registry);
+ /**
+ * metrics - number of successful authorizations
+ */
public final MetricsTimeVaryingInt authorizationSuccesses =
new MetricsTimeVaryingInt("rpcAuthorizationSuccesses", registry);
+
/**
* Push the metrics to the monitoring subsystem on doUpdate() call.
*/
@@ -111,6 +142,9 @@ public class RpcMetrics implements Updat
metricsRecord.update();
}
+ /**
+ * shutdown the metrics
+ */
public void shutdown() {
if (rpcMBean != null)
rpcMBean.shutdown();
Modified: hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/security/UserGroupInformation.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/security/UserGroupInformation.java?rev=1077441&r1=1077440&r2=1077441&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/security/UserGroupInformation.java (original)
+++ hadoop/common/branches/branch-0.20-security-patches/src/core/org/apache/hadoop/security/UserGroupInformation.java Fri Mar 4 04:15:22 2011
@@ -761,6 +761,9 @@ public class UserGroupInformation {
return result;
}
+ /**
+ * existing types of authentications' methods
+ */
public static enum AuthenticationMethod {
SIMPLE,
KERBEROS,
@@ -770,7 +773,8 @@ public class UserGroupInformation {
PROXY;
}
- /* Create a proxy user using username of the effective user and the ugi of the
+ /**
+ * Create a proxy user using username of the effective user and the ugi of the
* real user.
*
* @param effective
@@ -794,6 +798,10 @@ public class UserGroupInformation {
return result;
}
+ /**
+ * get RealUser (vs. EffectiveUser)
+ * @return realUser running over proxy user
+ */
public UserGroupInformation getRealUser() {
for (RealUser p: subject.getPrincipals(RealUser.class)) {
return p.getRealUser();