[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3523: Refactor some redunant code && Replace some UT by UtFrameUtils

[GitBox <gi...@apache.org>]

WingsGo commented on a change in pull request #3523:
URL: https://github.com/apache/incubator-doris/pull/3523#discussion_r422629684



##########
File path: fe/src/main/java/org/apache/doris/backup/RestoreJob.java
##########
@@ -806,7 +739,54 @@ private void checkAndPrepareMeta() {
         // No log here, PENDING state restore job will redo this method
         LOG.info("finished to prepare meta and send snapshot tasks, num: {}. {}",
                  batchTask.getTaskNum(), this);
-        return;
+    }
+
+    private boolean backupReplicasNotEqual(PartitionInfo localPartInfo, Partition localPartition, Table localTbl,

Review comment:
       can we change the method name to `genFileMappingWhenBackupReplicasEqual`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org