You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by GitBox <gi...@apache.org> on 2020/07/17 20:36:44 UTC
[GitHub] [mahout] balashashanka opened a new pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
balashashanka opened a new pull request #402:
URL: https://github.com/apache/mahout/pull/402
### Purpose of PR:
Removing the file endings of NOTICE.txt LICENSE.txt to make sure file is not replicated
### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
- [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [x] Successfully built and ran all unit tests, verified that all tests pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Does this change break earlier versions? - NO
Is this the beginning of a larger project for which a feature branch should be made? - NO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
rawkintrevo commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-661130957
ah yea- we turned that off bc we were having some issues with spam a while ago. I can assign to you or I can grant you permissions. Let me know which you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] andrewmusselman commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
andrewmusselman commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-662679306
Thanks for the help Shashanka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [mahout] balashashanka commented on pull request #402:
MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE
and NOTICE.txt
Posted by Trevor Grant <tr...@gmail.com>.
ah yea- we turned that off bc we were having some issues with spam a while
ago. I can assign to you or I can grant you permissions. Let me know which
you prefer.
On Mon, Jul 20, 2020 at 9:56 AM GitBox <gi...@apache.org> wrote:
>
> balashashanka commented on pull request #402:
> URL: https://github.com/apache/mahout/pull/402#issuecomment-661091530
>
>
> Hi, yes the WIP is because of no docs and etc not done. And I dont seem
> to have permissions to assign the JIRA to myself.
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
[GitHub] [mahout] balashashanka commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
balashashanka commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-661091530
Hi, yes the WIP is because of no docs and etc not done. And I dont seem to have permissions to assign the JIRA to myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] chrisdutz commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-661044509
Looks good to me and should to the trick nicely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
rawkintrevo commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-661046226
Yea.. @balashashanka is this just WIP because no docs/licesnses/unit tests? e.g. there's obviously a JIRA ticket for this- did you assign to yourself?
Assuming it is and you do, will merge this right after release (we're in code freeze rn)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
rawkintrevo commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-662671420
i granted you contributor rights @balashashanka . Thanks again for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] balashashanka commented on pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
balashashanka commented on pull request #402:
URL: https://github.com/apache/mahout/pull/402#issuecomment-661146386
Anything would do, my JIRA username is "balaShashanka".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo merged pull request #402: MAHOUT-2114 [WIP] Archive contains LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt
Posted by GitBox <gi...@apache.org>.
rawkintrevo merged pull request #402:
URL: https://github.com/apache/mahout/pull/402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org