You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by bu...@apache.org on 2010/05/06 13:52:46 UTC
DO NOT REPLY [Bug 49257] New: DSIGTransformXSL - Stylesheet missing
in XMLSignature output
https://issues.apache.org/bugzilla/show_bug.cgi?id=49257
Summary: DSIGTransformXSL - Stylesheet missing in XMLSignature
output
Product: Security
Version: C++ 1.5.1
Platform: PC
OS/Version: Windows NT
Status: NEW
Severity: normal
Priority: P2
Component: C++ Signature
AssignedTo: security-dev@xml.apache.org
ReportedBy: hagelkruys@a-trust.at
When appending an XSL Transform to an DSIG Reference, the XSL source is missing
in the output.
Cause:
In DSIGTransformXSL::createBlankTransform the mp_stylesheetNode is set to NULL.
When calloig setStylesheet, the stylesheet is copied to mp_stylesheetNode, but
it is not append to mp_txfmNode, because of the following condition
if (mp_stylesheetNode != 0)
{}
I think the best solution to work around this problem is to add an else to this
if condition:
else
{
mp_txfmNode->appendChild(mp_stylesheetNode);
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49257] DSIGTransformXSL - Stylesheet missing in
XMLSignature output
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49257
hagelkruys@a-trust.at changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #2 from hagelkruys@a-trust.at 2010-05-06 13:21:16 EDT ---
thx for fixing, the stylesheet now appears in the resulting transform.
but the fix has another little problem, if I pass NULL to appendXSLTransform()
the fixed code calls mp_txfmNode->appendChild(NULL) an crashes.
To be on the safe side stylesheet should be tested to NULL
if (mp_stylesheetNode) {
mp_txfmNode->insertBefore(stylesheet, mp_stylesheetNode);
mp_txfmNode->removeChild(mp_stylesheetNode);
}
else {
if(stylesheet) {
mp_txfmNode->appendChild(stylesheet);
}
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49257] DSIGTransformXSL - Stylesheet missing in
XMLSignature output
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49257
Scott Cantor <ca...@osu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Scott Cantor <ca...@osu.edu> 2010-05-06 10:37:00 EDT ---
http://svn.apache.org/viewvc?view=revision&revision=941755
I don't use XSLT (I'm maintaining the library but don't use most of the
features), so it would be good if you could test an svn build.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 49257] DSIGTransformXSL - Stylesheet missing in
XMLSignature output
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49257
Scott Cantor <ca...@osu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #3 from Scott Cantor <ca...@osu.edu> 2010-05-06 14:07:45 EDT ---
http://svn.apache.org/viewvc?view=revision&revision=941834
(Should have been broken originally as well, since insertBefore ought to crash
also.)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.