You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/03 02:43:17 UTC

[GitHub] [pulsar] codelipenghui opened a new issue #7723: Throttle the ledger rollover

codelipenghui opened a new issue #7723:
URL: https://github.com/apache/pulsar/issues/7723


   **Is your feature request related to a problem? Please describe.**
   High ledger rollover frequency may lead to zookeeper in heavy workload. In order to make zookeeper run more stable, we should limit the ledger rollover frequency.
   
   **Describe the solution you'd like**
   Add a rate limiter for the ledger rollover. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on issue #7723: Throttle the ledger rollover

Posted by GitBox <gi...@apache.org>.
Jason918 commented on issue #7723:
URL: https://github.com/apache/pulsar/issues/7723#issuecomment-865911237


   @codelipenghui HI, I'll be happy to participate. 
   Please check this more detailed solution.
   Add a new parameter `managedLedgerRolloverRateLimit`, rate limit the amount of rollover per second in one broker. This parameter can be set as 0 by default meaning no rate limiting .
   
   As `ManagedLedgerImpl#currentLedgerIsFull` is called before each ledger rollover, we can add a global rate limiter after that. Every ledger rollover can only happen when `currentLedgerIsFull()` and `rolloverRatelimiter.tryAcquire()` both return true.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org