You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/03 09:30:53 UTC
[GitHub] [cassandra-builds] nastra opened a new pull request #25: Run dtest upgrade tests
nastra opened a new pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever closed pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] nastra commented on a change in pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#discussion_r435702967
##########
File path: build-scripts/cassandra-dtest-pytest.sh
##########
@@ -21,6 +21,7 @@ export CASSANDRA_DIR=${WORKSPACE}
#Have Cassandra skip all fsyncs to improve test performance and reliability
export CASSANDRA_SKIP_SYNC=true
export TMPDIR="./tmp"
+export RUN_STATIC_UPGRADE_MATRIX=true
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#discussion_r435522824
##########
File path: build-scripts/cassandra-dtest-pytest.sh
##########
@@ -21,6 +21,7 @@ export CASSANDRA_DIR=${WORKSPACE}
#Have Cassandra skip all fsyncs to improve test performance and reliability
export CASSANDRA_SKIP_SYNC=true
export TMPDIR="./tmp"
+export RUN_STATIC_UPGRADE_MATRIX=true
Review comment:
looks like the move is necessary, after running https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-dtest/146/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] nastra commented on a change in pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#discussion_r434514713
##########
File path: build-scripts/cassandra-dtest-pytest.sh
##########
@@ -73,6 +74,8 @@ elif [ "${DTEST_TARGET}" = "dtest-offheap" ]; then
pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32 --use-off-heap-memtables --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR --skip-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
elif [ "${DTEST_TARGET}" = "dtest-large" ]; then
pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32 --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR --only-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
+elif [ "${DTEST_TARGET}" = "dtest-upgrade" ]; then
+ pytest -vv --log-level="INFO" --execute-upgrade-tests --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
Review comment:
don't think so. The upgrade tests in CircleCI also test with vnodes disabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#discussion_r435503898
##########
File path: build-scripts/cassandra-dtest-pytest.sh
##########
@@ -21,6 +21,7 @@ export CASSANDRA_DIR=${WORKSPACE}
#Have Cassandra skip all fsyncs to improve test performance and reliability
export CASSANDRA_SKIP_SYNC=true
export TMPDIR="./tmp"
+export RUN_STATIC_UPGRADE_MATRIX=true
Review comment:
wonder if it is better/safer to move this line to inside just the case for "dtest-upgrade" (i.e. lines 76-77) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#issuecomment-638451981
Testing happening at https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-dtest-upgrade/3/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#issuecomment-639332175
merged with https://github.com/apache/cassandra-builds/commit/94f2b784fac3142164fc7fb667f132450a3fbfaa
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] snazy commented on a change in pull request #25: Run dtest upgrade tests
Posted by GitBox <gi...@apache.org>.
snazy commented on a change in pull request #25:
URL: https://github.com/apache/cassandra-builds/pull/25#discussion_r434472875
##########
File path: build-scripts/cassandra-dtest-pytest.sh
##########
@@ -73,6 +74,8 @@ elif [ "${DTEST_TARGET}" = "dtest-offheap" ]; then
pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32 --use-off-heap-memtables --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR --skip-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
elif [ "${DTEST_TARGET}" = "dtest-large" ]; then
pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32 --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR --only-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
+elif [ "${DTEST_TARGET}" = "dtest-upgrade" ]; then
+ pytest -vv --log-level="INFO" --execute-upgrade-tests --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
Review comment:
Does this need `--use-vnodes` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org