You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2012/01/13 23:40:39 UTC
[jira] [Created] (HBASE-5197) [replication] Handle socket timeouts
in ReplicationSource to prevent DDOS
[replication] Handle socket timeouts in ReplicationSource to prevent DDOS
-------------------------------------------------------------------------
Key: HBASE-5197
URL: https://issues.apache.org/jira/browse/HBASE-5197
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.5
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Fix For: 0.94.0, 0.92.1, 0.90.6
Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212163#comment-13212163 ]
Hudson commented on HBASE-5197:
-------------------------------
Integrated in HBase-0.92-security #91 (See [https://builds.apache.org/job/HBase-0.92-security/91/])
HBASE-5197 [replication] Handle socket timeouts in ReplicationSource
to prevent DDOS (Revision 1243736)
Result = FAILURE
jdcryans :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207275#comment-13207275 ]
Zhihong Yu commented on HBASE-5197:
-----------------------------------
Patch looks good.
Minor comment:
{code}
+ maxRetriesMultiplier * maxRetriesMultiplier);
{code}
Can store the result of above computation in a variable ?
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.7, 0.92.1
>
> Attachments: HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5197) [replication] Handle socket timeouts
in ReplicationSource to prevent DDOS
Posted by "Jean-Daniel Cryans (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-5197.
---------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.90.7)
0.90.6
Hadoop Flags: Reviewed
Committed to both branches and trunk, thanks for the review Ted.
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209410#comment-13209410 ]
Hudson commented on HBASE-5197:
-------------------------------
Integrated in HBase-TRUNK #2663 (See [https://builds.apache.org/job/HBase-TRUNK/2663/])
HBASE-5197 [replication] Handle socket timeouts in ReplicationSource
to prevent DDOS (Revision 1243733)
Result = FAILURE
jdcryans :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5197) [replication] Handle socket timeouts
in ReplicationSource to prevent DDOS
Posted by "Jean-Daniel Cryans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-5197:
--------------------------------------
Attachment: HBASE-5197-v2.patch
More like this?
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.7, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207533#comment-13207533 ]
Hudson commented on HBASE-5197:
-------------------------------
Integrated in HBase-TRUNK-security #111 (See [https://builds.apache.org/job/HBase-TRUNK-security/111/])
HBASE-5197 [replication] Handle socket timeouts in ReplicationSource
to prevent DDOS (Revision 1243733)
Result = SUCCESS
jdcryans :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207455#comment-13207455 ]
Hudson commented on HBASE-5197:
-------------------------------
Integrated in HBase-0.92 #279 (See [https://builds.apache.org/job/HBase-0.92/279/])
HBASE-5197 [replication] Handle socket timeouts in ReplicationSource
to prevent DDOS (Revision 1243736)
Result = FAILURE
jdcryans :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5197) [replication] Handle socket timeouts
in ReplicationSource to prevent DDOS
Posted by "Jean-Daniel Cryans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-5197:
--------------------------------------
Attachment: HBASE-5197.patch
Adding the handling of the exception with a sleep of 100 seconds by default. In my testing this has prevented DDOSing.
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.7, 0.92.1
>
> Attachments: HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5197) [replication] Handle socket
timeouts in ReplicationSource to prevent DDOS
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207304#comment-13207304 ]
Zhihong Yu commented on HBASE-5197:
-----------------------------------
Patch v2 looks good.
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.7, 0.92.1
>
> Attachments: HBASE-5197-v2.patch, HBASE-5197.patch
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5197) [replication] Handle socket timeouts
in ReplicationSource to prevent DDOS
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5197:
------------------------------------------
Fix Version/s: (was: 0.90.6)
0.90.7
Updating affect versions to 0.90.7
> [replication] Handle socket timeouts in ReplicationSource to prevent DDOS
> -------------------------------------------------------------------------
>
> Key: HBASE-5197
> URL: https://issues.apache.org/jira/browse/HBASE-5197
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.94.0, 0.90.7, 0.92.1
>
>
> Kind of like HBASE-4462 but for replication. If while replicating you get a socket timeout, the last thing you want to do is to retry it right away. Since we can't fail the replication thread, the best I can think of is to sleep a really long amount of time.
> Planning to bring this to all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira