[GitHub] [calcite] libenchao commented on a diff in pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests

["libenchao (via GitHub)" <gi...@apache.org>]

libenchao commented on code in PR #3278:
URL: https://github.com/apache/calcite/pull/3278#discussion_r1240586484


##########
build.gradle.kts:
##########
@@ -202,6 +202,7 @@ val javadocAggregateIncludingTests by tasks.registering(Javadoc::class) {
     description = "Generates aggregate javadoc for all the artifacts"
 
     val sourceSets = subprojects
+        .filter { it.name != "bom" }

Review Comment:
   `javadocAggregate` section uses `.filter { it.names.contains("main") }`, we'd better to keep them consistent? (Both way looks good to me).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org