You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 18:20:43 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #2085: Handle offset consistently for StructArray (#1750)

tustvold opened a new pull request, #2085:
URL: https://github.com/apache/arrow-rs/pull/2085

   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1750
   
   # Rationale for this change
    
   The special casing of StructArray is inconsistent with how offsets are handled for all other types. This makes an already very confusing parameter, even more confusing.
   
   # What changes are included in this PR?
   
   <!---
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Removes the special-casing of StructArray in ArrayData::slice, instead handling it within the Array implementation as is done for all other array types. Longer term we may want to revisit the offset field, #1799, but until then we should be consistent.
   
   # Are there any user-facing changes?
   
   Sort of, whilst extremely unlikely any code is actually doing this, it was possible to manually construct an ArrayData for a StructArray with a non-zero offset. This will not behave correctly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed pull request #2085: Handle offset consistently for StructArray (#1750)

Posted by GitBox <gi...@apache.org>.
tustvold closed pull request #2085: Handle offset consistently for StructArray (#1750)
URL: https://github.com/apache/arrow-rs/pull/2085


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #2085: Handle offset consistently for StructArray (#1750)

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2085:
URL: https://github.com/apache/arrow-rs/pull/2085#issuecomment-1186004342

   Having thought a bit about this, rather than introduce two breaking changes - one to make the offsets consistent, and then one to remove them, I'd rather just remove them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org