You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger L. Whitcomb" <Ro...@ingres.com> on 2010/09/20 18:25:09 UTC
Small bug in 1.5.x in Javadoc
Hi,
I was generating Javadoc in the 1.5.x branch and I
noticed this warning:
[javadoc] Building tree for all the packages and classes...
[javadoc]
C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
t\TreeBranch.java:116: warning - @param argument
"expandedIconURL" is not a parameter name.
Here is the patch to fix this:
Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
===================================================================
--- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
997887)
+++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
copy)
@@ -108,7 +108,7 @@
* application context's {@linkplain
ApplicationContext#getResourceCache()
* resource cache} if one does not already exist.
*
- * @param expandedIconURL
+ * @param expandedIconName
* The resource name of the expanded icon to set.
*
* @see #setExpandedIcon(URL)
Roger Whitcomb
Architect, Engineering
Ingres Corporation
roger.whitcomb@ingres.com <ma...@ingres.com>
PHONE +1 650.587.5596
FAX +1 650.587.5550
www.ingres.com <http://www.ingres.com/>
This transmission is confidential and intended solely for the use of the
recipient named above. It may contain confidential, proprietary, or
legally privileged information. If you are not the intended recipient,
you are hereby notified that any unauthorized review, use, disclosure or
distribution is strictly prohibited. If you have received this
transmission in error, please contact the sender by reply e-mail and
delete the original transmission and all copies from your system.
Re: Small bug in 1.5.x in Javadoc
Posted by Greg Brown <gk...@mac.com>.
You are correct, I had updated them in trunk but not 1.5.x. This is fixed now.
On Sep 21, 2010, at 1:12 PM, Roger L. Whitcomb wrote:
> I just pulled head revs of "trunk" and "1.5.x" from SVN about 2 minutes
> ago and while both issues appear to be fixed in "trunk", but neither was
> fixed (yet) in "1.5.x"... Is there a delay in updating SVN? I checked
> out revision 999499.
>
> Roger Whitcomb | Architect, Engineering | Roger.Whitcomb@ingres.com |
> Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
> USA +1 650-587-5596 | fax: +1 650-587-5550
>
> -----Original Message-----
> From: Greg Brown [mailto:gkbrown@mac.com]
> Sent: Tuesday, September 21, 2010 8:47 AM
> To: dev@pivot.apache.org
> Subject: Re: Small bug in 1.5.x in Javadoc
>
> I believe this particular issue has already been resolved for 1.5.2, but
> I wasn't aware of the other one. It's fixed now - thanks.
>
>
> On Sep 20, 2010, at 12:25 PM, Roger L. Whitcomb wrote:
>
>> Hi,
>>
>> I was generating Javadoc in the 1.5.x branch and I
>> noticed this warning:
>>
>> [javadoc] Building tree for all the packages and classes...
>>
>> [javadoc]
>>
> C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
>> t\TreeBranch.java:116: warning - @param argument
>>
>> "expandedIconURL" is not a parameter name.
>>
>>
>>
>> Here is the patch to fix this:
>>
>> Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
>>
>> ===================================================================
>>
>> --- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
>> 997887)
>>
>> +++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
>> copy)
>>
>> @@ -108,7 +108,7 @@
>>
>> * application context's {@linkplain
>> ApplicationContext#getResourceCache()
>>
>> * resource cache} if one does not already exist.
>>
>> *
>>
>> - * @param expandedIconURL
>>
>> + * @param expandedIconName
>>
>> * The resource name of the expanded icon to set.
>>
>> *
>>
>> * @see #setExpandedIcon(URL)
>>
>>
>>
>>
>>
>>
>>
>> Roger Whitcomb
>>
>> Architect, Engineering
>>
>> Ingres Corporation
>>
>> roger.whitcomb@ingres.com <ma...@ingres.com>
>>
>>
>>
>> PHONE +1 650.587.5596
>>
>> FAX +1 650.587.5550
>>
>>
>>
>> www.ingres.com <http://www.ingres.com/>
>>
>>
>>
>> This transmission is confidential and intended solely for the use of
> the
>> recipient named above. It may contain confidential, proprietary, or
>> legally privileged information. If you are not the intended recipient,
>> you are hereby notified that any unauthorized review, use, disclosure
> or
>> distribution is strictly prohibited. If you have received this
>> transmission in error, please contact the sender by reply e-mail and
>> delete the original transmission and all copies from your system.
>>
>>
>>
>
RE: Small bug in 1.5.x in Javadoc
Posted by "Roger L. Whitcomb" <Ro...@ingres.com>.
I just pulled head revs of "trunk" and "1.5.x" from SVN about 2 minutes
ago and while both issues appear to be fixed in "trunk", but neither was
fixed (yet) in "1.5.x"... Is there a delay in updating SVN? I checked
out revision 999499.
Roger Whitcomb | Architect, Engineering | Roger.Whitcomb@ingres.com |
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA +1 650-587-5596 | fax: +1 650-587-5550
-----Original Message-----
From: Greg Brown [mailto:gkbrown@mac.com]
Sent: Tuesday, September 21, 2010 8:47 AM
To: dev@pivot.apache.org
Subject: Re: Small bug in 1.5.x in Javadoc
I believe this particular issue has already been resolved for 1.5.2, but
I wasn't aware of the other one. It's fixed now - thanks.
On Sep 20, 2010, at 12:25 PM, Roger L. Whitcomb wrote:
> Hi,
>
> I was generating Javadoc in the 1.5.x branch and I
> noticed this warning:
>
> [javadoc] Building tree for all the packages and classes...
>
> [javadoc]
>
C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
> t\TreeBranch.java:116: warning - @param argument
>
> "expandedIconURL" is not a parameter name.
>
>
>
> Here is the patch to fix this:
>
> Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
>
> ===================================================================
>
> --- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
> 997887)
>
> +++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
> copy)
>
> @@ -108,7 +108,7 @@
>
> * application context's {@linkplain
> ApplicationContext#getResourceCache()
>
> * resource cache} if one does not already exist.
>
> *
>
> - * @param expandedIconURL
>
> + * @param expandedIconName
>
> * The resource name of the expanded icon to set.
>
> *
>
> * @see #setExpandedIcon(URL)
>
>
>
>
>
>
>
> Roger Whitcomb
>
> Architect, Engineering
>
> Ingres Corporation
>
> roger.whitcomb@ingres.com <ma...@ingres.com>
>
>
>
> PHONE +1 650.587.5596
>
> FAX +1 650.587.5550
>
>
>
> www.ingres.com <http://www.ingres.com/>
>
>
>
> This transmission is confidential and intended solely for the use of
the
> recipient named above. It may contain confidential, proprietary, or
> legally privileged information. If you are not the intended recipient,
> you are hereby notified that any unauthorized review, use, disclosure
or
> distribution is strictly prohibited. If you have received this
> transmission in error, please contact the sender by reply e-mail and
> delete the original transmission and all copies from your system.
>
>
>
Re: Small bug in 1.5.x in Javadoc
Posted by Greg Brown <gk...@mac.com>.
I believe this particular issue has already been resolved for 1.5.2, but I wasn't aware of the other one. It's fixed now - thanks.
On Sep 20, 2010, at 12:25 PM, Roger L. Whitcomb wrote:
> Hi,
>
> I was generating Javadoc in the 1.5.x branch and I
> noticed this warning:
>
> [javadoc] Building tree for all the packages and classes...
>
> [javadoc]
> C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
> t\TreeBranch.java:116: warning - @param argument
>
> "expandedIconURL" is not a parameter name.
>
>
>
> Here is the patch to fix this:
>
> Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
>
> ===================================================================
>
> --- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
> 997887)
>
> +++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
> copy)
>
> @@ -108,7 +108,7 @@
>
> * application context's {@linkplain
> ApplicationContext#getResourceCache()
>
> * resource cache} if one does not already exist.
>
> *
>
> - * @param expandedIconURL
>
> + * @param expandedIconName
>
> * The resource name of the expanded icon to set.
>
> *
>
> * @see #setExpandedIcon(URL)
>
>
>
>
>
>
>
> Roger Whitcomb
>
> Architect, Engineering
>
> Ingres Corporation
>
> roger.whitcomb@ingres.com <ma...@ingres.com>
>
>
>
> PHONE +1 650.587.5596
>
> FAX +1 650.587.5550
>
>
>
> www.ingres.com <http://www.ingres.com/>
>
>
>
> This transmission is confidential and intended solely for the use of the
> recipient named above. It may contain confidential, proprietary, or
> legally privileged information. If you are not the intended recipient,
> you are hereby notified that any unauthorized review, use, disclosure or
> distribution is strictly prohibited. If you have received this
> transmission in error, please contact the sender by reply e-mail and
> delete the original transmission and all copies from your system.
>
>
>
Re: Small bug in 1.5.x in Javadoc
Posted by Chris Bartlett <cb...@gmail.com>.
Thanks Roger.
I noticed the QueryServlet one in trunk on Friday night but didn't have time
to address it before breaking for the weekend.
I'm sure there that somewhere there is a document fully explaining the
policy for accepting patches, but for now I can't locate one.
In it absence I'll quote Todd Volkert from a recent mail.
> FYI, we're legally obliged to have you submit any potential patches
> through JIRA, because the act of checking the license grant checkbox
> is important from a legal perspective.
http://apache-pivot-developers.417237.n3.nabble.com/Re-Best-practice-for-implementing-Actions-tp1447175p1448665.html
I don't think there is a need for you to resubmit this patch (unless you
really want to!) as it is just a warning and should be caught during test
builds in the pre-release process (if not well before).
Thanks anyway though.
Regards,
Chris
On 20 September 2010 23:36, Roger L. Whitcomb <Ro...@ingres.com>wrote:
> Actually there is another one in the latest head revs of 1.5.x:
> [javadoc]
> C:\Projects\Pivot\svn\branches\1.5.x\web-server\src\org\apache\pivot\web
> \server\QueryServlet.java:236: warning - Tag @link: can't find
> validate(Path) in org.apache.pivot.web.server.QueryServlet
>
> Roger Whitcomb | Architect, Engineering | Roger.Whitcomb@ingres.com |
> Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
> USA +1 650-587-5596 | fax: +1 650-587-5550
> -----Original Message-----
> From: Roger L. Whitcomb [mailto:Roger.Whitcomb@ingres.com]
> Sent: Monday, September 20, 2010 9:25 AM
> To: dev@pivot.apache.org
> Subject: Small bug in 1.5.x in Javadoc
>
> Hi,
>
> I was generating Javadoc in the 1.5.x branch and I
> noticed this warning:
>
> [javadoc] Building tree for all the packages and classes...
>
> [javadoc]
> C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
> t\TreeBranch.java:116: warning - @param argument
>
> "expandedIconURL" is not a parameter name.
>
>
>
> Here is the patch to fix this:
>
> Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
>
> ===================================================================
>
> --- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
> 997887)
>
> +++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
> copy)
>
> @@ -108,7 +108,7 @@
>
> * application context's {@linkplain
> ApplicationContext#getResourceCache()
>
> * resource cache} if one does not already exist.
>
> *
>
> - * @param expandedIconURL
>
> + * @param expandedIconName
>
> * The resource name of the expanded icon to set.
>
> *
>
> * @see #setExpandedIcon(URL)
>
>
>
>
>
>
>
> Roger Whitcomb
>
> Architect, Engineering
>
> Ingres Corporation
>
> roger.whitcomb@ingres.com <ma...@ingres.com>
>
>
>
> PHONE +1 650.587.5596
>
> FAX +1 650.587.5550
>
>
>
> www.ingres.com <http://www.ingres.com/>
>
>
>
> This transmission is confidential and intended solely for the use of the
> recipient named above. It may contain confidential, proprietary, or
> legally privileged information. If you are not the intended recipient,
> you are hereby notified that any unauthorized review, use, disclosure or
> distribution is strictly prohibited. If you have received this
> transmission in error, please contact the sender by reply e-mail and
> delete the original transmission and all copies from your system.
>
>
>
>
RE: Small bug in 1.5.x in Javadoc
Posted by "Roger L. Whitcomb" <Ro...@ingres.com>.
Actually there is another one in the latest head revs of 1.5.x:
[javadoc]
C:\Projects\Pivot\svn\branches\1.5.x\web-server\src\org\apache\pivot\web
\server\QueryServlet.java:236: warning - Tag @link: can't find
validate(Path) in org.apache.pivot.web.server.QueryServlet
Roger Whitcomb | Architect, Engineering | Roger.Whitcomb@ingres.com |
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA +1 650-587-5596 | fax: +1 650-587-5550
-----Original Message-----
From: Roger L. Whitcomb [mailto:Roger.Whitcomb@ingres.com]
Sent: Monday, September 20, 2010 9:25 AM
To: dev@pivot.apache.org
Subject: Small bug in 1.5.x in Javadoc
Hi,
I was generating Javadoc in the 1.5.x branch and I
noticed this warning:
[javadoc] Building tree for all the packages and classes...
[javadoc]
C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten
t\TreeBranch.java:116: warning - @param argument
"expandedIconURL" is not a parameter name.
Here is the patch to fix this:
Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java
===================================================================
--- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision
997887)
+++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working
copy)
@@ -108,7 +108,7 @@
* application context's {@linkplain
ApplicationContext#getResourceCache()
* resource cache} if one does not already exist.
*
- * @param expandedIconURL
+ * @param expandedIconName
* The resource name of the expanded icon to set.
*
* @see #setExpandedIcon(URL)
Roger Whitcomb
Architect, Engineering
Ingres Corporation
roger.whitcomb@ingres.com <ma...@ingres.com>
PHONE +1 650.587.5596
FAX +1 650.587.5550
www.ingres.com <http://www.ingres.com/>
This transmission is confidential and intended solely for the use of the
recipient named above. It may contain confidential, proprietary, or
legally privileged information. If you are not the intended recipient,
you are hereby notified that any unauthorized review, use, disclosure or
distribution is strictly prohibited. If you have received this
transmission in error, please contact the sender by reply e-mail and
delete the original transmission and all copies from your system.