You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li <li...@cloudera.com> on 2017/09/08 21:59:24 UTC
Review Request 62195: SENTRY-1934: SQL Index name is too long for
Oracle 11.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62195/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee Yarlagadda.
Repository: sentry
Description
-------
make the index shorter than 30 bytes
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 88d7378
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 49b7959
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 0bda5cd
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 8dd8316
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql 2610d6c
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql 1661412
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql 1b95622
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql f033895
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 1b5cd04
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql d6d222e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql 6340520
Diff: https://reviews.apache.org/r/62195/diff/1/
Testing
-------
test on Oracle DB 11.2. The changed index works
Thanks,
Na Li
Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for
Oracle 11.2
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62195/#review185023
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 8, 2017, 9:59 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62195/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 9:59 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> make the index shorter than 30 bytes
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 88d7378
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 49b7959
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 0bda5cd
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 8dd8316
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql 2610d6c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql 1661412
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql 1b95622
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql f033895
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 1b5cd04
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql d6d222e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql 6340520
>
>
> Diff: https://reviews.apache.org/r/62195/diff/1/
>
>
> Testing
> -------
>
> test on Oracle DB 11.2. The changed index works
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for
Oracle 11.2
Posted by Na Li <li...@cloudera.com>.
> On Sept. 8, 2017, 10:03 p.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Line 323 (original), 323 (patched)
> > <https://reviews.apache.org/r/62195/diff/1/?file=1818613#file1818613line323>
> >
> > Why do we need work SENTRY? It is completely redundand - just remove it
It is using the same prefix of the table name
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62195/#review185022
-----------------------------------------------------------
On Sept. 8, 2017, 9:59 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62195/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 9:59 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> make the index shorter than 30 bytes
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 88d7378
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 49b7959
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 0bda5cd
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 8dd8316
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql 2610d6c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql 1661412
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql 1b95622
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql f033895
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 1b5cd04
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql d6d222e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql 6340520
>
>
> Diff: https://reviews.apache.org/r/62195/diff/1/
>
>
> Testing
> -------
>
> test on Oracle DB 11.2. The changed index works
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for
Oracle 11.2
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62195/#review185022
-----------------------------------------------------------
This is fine, but better would be to remove SENTRY from the name.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
Line 323 (original), 323 (patched)
<https://reviews.apache.org/r/62195/#comment261255>
Why do we need work SENTRY? It is completely redundand - just remove it
- Alexander Kolbasov
On Sept. 8, 2017, 9:59 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62195/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 9:59 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> make the index shorter than 30 bytes
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 88d7378
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql 49b7959
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 0bda5cd
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql 8dd8316
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql 2610d6c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql 1661412
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql 1b95622
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql f033895
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql 1b5cd04
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql d6d222e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql 6340520
>
>
> Diff: https://reviews.apache.org/r/62195/diff/1/
>
>
> Testing
> -------
>
> test on Oracle DB 11.2. The changed index works
>
>
> Thanks,
>
> Na Li
>
>