You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/06/09 10:04:39 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/96
ZEPPELIN-74 Change interpreter selection from %[Name] to %[Group].[Name]
This PR implements https://issues.apache.org/jira/browse/ZEPPELIN-74.
Plus, changing existing interpreter's name
spark.spark -> spark.scala
spark.pyspark -> spark.py
hive.hive -> hive.hql
tajo.tajo -> tajo.tql
All changes are backward compatible except for spark.pyspark -> spark.py.
User need either %spark.py, %py (when Spark is selected first) instead of %pyspark.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-74
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 335bc8f9f3e860f3e65adb51ea46b5d4117d5d9c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:52:28Z
ZEPPELIN-74 Change interpreter selection from %[Name] to %[Group].[Name]
commit 0e2cfb3e9602265ae4ba906ba3de6b202d19046f
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:53:26Z
Rename spark.pyspark -> spark.py, spark.spark -> spark.scala
commit 96705ab7c3279a5a06ae4c6a2a6adce9adeff95c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:55:22Z
hive.hive -> hive.hql
commit a5496bc6549a977957f9022d34cd5598f625a965
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:55:35Z
tajo.tajo -> tajo.tql
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-114257727
I have reverted interpreter name PysparkInterpreter name from py to pyspark. and SparkInterpreter from scala -> spark. So there will be no backward compatibility issue.
About renaming spark.pyspark->spark.py, spark.spark->spark.scala, I think i can still create separate issue and discuss there.
Now tests are passing. Ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-113971675
Still failing :(
BTW shoud [docs update](http://zeppelin.incubator.apache.org/docs/development/writingzeppelininterpreter.html) be part of this PR or do you want to hande it in a sepate one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-113973389
I'll handle it in separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-111034114
all test are passed but travis is somehow goes to after_failure lifecycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-111428390
Can you try 'close and re-open' this PR - this is a 'hack' to re-trigger the CI and see if that is reproducible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/96
ZEPPELIN-74 Change interpreter selection from %[Name] to %[Group].[Name]
This PR implements https://issues.apache.org/jira/browse/ZEPPELIN-74.
Plus, changing existing interpreter's name
spark.spark -> spark.scala
spark.pyspark -> spark.py
hive.hive -> hive.hql
tajo.tajo -> tajo.tql
All changes are backward compatible except for spark.pyspark -> spark.py.
User need either %spark.py, %py (when Spark is selected first) instead of %pyspark.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-74
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 335bc8f9f3e860f3e65adb51ea46b5d4117d5d9c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:52:28Z
ZEPPELIN-74 Change interpreter selection from %[Name] to %[Group].[Name]
commit 0e2cfb3e9602265ae4ba906ba3de6b202d19046f
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:53:26Z
Rename spark.pyspark -> spark.py, spark.spark -> spark.scala
commit 96705ab7c3279a5a06ae4c6a2a6adce9adeff95c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:55:22Z
hive.hive -> hive.hql
commit a5496bc6549a977957f9022d34cd5598f625a965
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T07:55:35Z
tajo.tajo -> tajo.tql
commit 9f9a9c3761a4903fddfb75cedc9ee1713f046070
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T09:10:11Z
Fix test
commit c656c4d92ef2e88255a3463cfde61f72eeb6ae1a
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-09T17:07:28Z
Commenting out unused travis lifecycle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-74 Change interpreter se...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/96#issuecomment-114584608
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---