[jira] [Comment Edited] (TAP5-2214) Make tapestry5 java8 compatible

["Kalle Korhonen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942171#comment-13942171 ] 

Kalle Korhonen edited comment on TAP5-2214 at 3/20/14 7:27 PM:
---------------------------------------------------------------

The patch did not apply cleanly, and besides there's ASM 5.0 final release so I just used the official source from asm.ow2.org. No changes to the rest of Plastic source were required so I believe T5.3 uses could just use T5.4 plastic library once this is released (or build from source). Perhaps we should create a new version number (5.4.0?) to indicate difference between beta release and the final, or whatever we are targeting next.


was (Author: kaosko):
The patch did not apply cleanly, and besides there's ASM 5.0 final release so I just used the official source from asm.ow2.org. No changes to the rest of Plastic source were required so I believe T5.3 uses could just use T5.4 plastic library once this is released (or build from source).

> Make tapestry5 java8 compatible
> -------------------------------
>
>                 Key: TAP5-2214
>                 URL: https://issues.apache.org/jira/browse/TAP5-2214
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: plastic
>    Affects Versions: 5.4
>            Reporter: Joachim Van der Auwera
>            Assignee: Kalle Korhonen
>         Attachments: 0001-use-asm-5.0_BETA-for-java8.patch, 0002-TAP5-2214-use-ASM-5.0_BETA-for-java8-compatibility.patch, plastic-5.3.7-mint-asm5-java8.jar
>
>
> As it stands Tapestry does not work on java8. This seems to be caused by ASM. Updating the enclosed asm to 5.0_Bet seems to do the trick.



--
This message was sent by Atlassian JIRA
(v6.2#6252)