[GitHub] [shardingsphere] Qianyi951015 commented on a diff in pull request #22945: Update DistSQL documents

[GitBox <gi...@apache.org>]

Qianyi951015 commented on code in PR #22945:
URL: https://github.com/apache/shardingsphere/pull/22945#discussion_r1051546911


##########
docs/document/content/reference/distsql/syntax/ral/global-rule/alter-traffic-rule.cn.md:
##########
@@ -17,10 +17,13 @@ lableName ::=
   identifier
 
 trafficAlgorithmDefination ::=
-  'TRAFFIC_ALGORITHM' '(' 'TYPE' '(' 'NAME' = trafficAlgorithmTypeName (',' 'PROPERTIES' '(' key '=' value (',' key '=' value)* ')')? ')' ')'
+  'TRAFFIC_ALGORITHM' '(' 'TYPE' '(' 'NAME' '=' trafficAlgorithmTypeName (propertiesDefination)? ')' ')'
 
 loadBalancerDefination ::=
-  'LOAD_BALANCER' '(' 'TYPE' '(' 'NAME' = loadBalancerName (',' 'PROPERTIES' '(' key '=' value (',' key '=' value)* ')')? ')' ')'
+  'LOAD_BALANCER' '(' 'TYPE' '(' 'NAME' '=' loadBalancerName (propertiesDefination)? ')' ')'
+
+propertiesDefination ::=
+  ',' 'PROPERTIES' '(' key '=' value (',' key '=' value)* ')'

Review Comment:
   Change like this better?
   ```
   'LOAD_BALANCER' '(' 'TYPE' '(' 'NAME' '=' loadBalancerName (',' propertiesDefination)? ')' ')'
   propertiesDefination ::=
      'PROPERTIES' '(' key '=' value (',' key '=' value)* ')'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org