You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2008/08/04 17:32:44 UTC
[jira] Created: (HADOOP-3896) MiniDFSCluster.stopDataNode will
always shut down a node in the cluster if a matching name is not found
MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
-------------------------------------------------------------------------------------------------------
Key: HADOOP-3896
URL: https://issues.apache.org/jira/browse/HADOOP-3896
Project: Hadoop Core
Issue Type: Bug
Reporter: Steve Loughran
The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found
This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located
synchronized boolean stopDataNode(String name) {
int i;
for (i = 0; i < dataNodes.size(); i++) {
DataNode dn = dataNodes.get(i).datanode;
if (dn.dnRegistration.getName().equals(name)) {
break;
}
}
return stopDataNode(i);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3896) MiniDFSCluster.stopDataNode will
always shut down a node in the cluster if a matching name is not found
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3896:
------------------------------------
Component/s: dfs
> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-3896
> URL: https://issues.apache.org/jira/browse/HADOOP-3896
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Steve Loughran
> Priority: Minor
>
> The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found
> This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located
> synchronized boolean stopDataNode(String name) {
> int i;
> for (i = 0; i < dataNodes.size(); i++) {
> DataNode dn = dataNodes.get(i).datanode;
> if (dn.dnRegistration.getName().equals(name)) {
> break;
> }
> }
> return stopDataNode(i);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3896) MiniDFSCluster.stopDataNode will
always shut down a node in the cluster if a matching name is not found
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3896:
-----------------------------------
Priority: Minor (was: Major)
marking as minor; the method is only used in TestDatanodeDeath
> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-3896
> URL: https://issues.apache.org/jira/browse/HADOOP-3896
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Steve Loughran
> Priority: Minor
>
> The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found
> This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located
> synchronized boolean stopDataNode(String name) {
> int i;
> for (i = 0; i < dataNodes.size(); i++) {
> DataNode dn = dataNodes.get(i).datanode;
> if (dn.dnRegistration.getName().equals(name)) {
> break;
> }
> }
> return stopDataNode(i);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.