You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/12 02:42:18 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #13913: [BEAM-7372][BEAM-9372] cleanup python 2.x and 3.5 codepaths

tvalentyn commented on a change in pull request #13913:
URL: https://github.com/apache/beam/pull/13913#discussion_r574959724



##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -31,17 +30,8 @@
 from apache_beam.dataframe import expressions
 from apache_beam.dataframe import partitionings
 
-# pylint: disable=deprecated-method
-if sys.version_info < (3, ):
-  _getargspec = inspect.getargspec
-
-  def _unwrap(func):
-    while hasattr(func, '__wrapped__'):
-      func = func.__wrapped__
-    return func
-else:
-  _getargspec = inspect.getfullargspec
-  _unwrap = inspect.unwrap
+_getargspec = inspect.getfullargspec

Review comment:
       we can remove these aliases now and add a normal import.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org