You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2013/07/12 20:40:00 UTC

Re: svn commit: r1502645 - /jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java

Thanks, that fixes the workbench display issue.

On 12 July 2013 19:36,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Fri Jul 12 18:36:08 2013
> New Revision: 1502645
>
> URL: http://svn.apache.org/r1502645
> Log:
> Bug 54834 - Improve Drag & Drop in the jmeter tree
> Select dropped nodes
> Bugzilla Id: 54834
>
> Modified:
>     jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java?rev=1502645&r1=1502644&r2=1502645&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java Fri Jul 12 18:36:08 2013
> @@ -236,6 +236,9 @@ public class JMeterTreeTransferHandler e
>
>          nodesForRemoval = new ArrayList<JMeterTreeNode>();
>          int index = dl.getChildIndex();
> +        TreePath[] pathsToSelect = new TreePath[nodes.length];
> +        int pathPosition = 0;
> +        JMeterTreeModel treeModel = guiInstance.getTreeModel();
>          for (JMeterTreeNode node : nodes) {
>
>              if (index == -1) { // drop mode == DropMode.ON
> @@ -259,14 +262,16 @@ public class JMeterTreeTransferHandler e
>              for (JMeterTreeNode jMeterTreeNode : tmp) {
>                  copy.add(jMeterTreeNode);
>              }
> -            guiInstance.getTreeModel().insertNodeInto(copy, target, index++);
> +            treeModel.insertNodeInto(copy, target, index++);
>              nodesForRemoval.add(node);
> +            pathsToSelect[pathPosition++] = new TreePath(treeModel.getPathToRoot(copy));
>          }
>
> +        TreePath treePath = new TreePath(target.getPath());
>          // expand the destination node
>          JTree tree = (JTree) support.getComponent();
> -        tree.expandPath(new TreePath(target.getPath()));
> -
> +        tree.expandPath(treePath);
> +        tree.setSelectionPaths(pathsToSelect);
>          return true;
>      }
>
>
>