You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/21 23:22:09 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request, #509: Fix non-recurring backups
HoustonPutman opened a new pull request, #509:
URL: https://github.com/apache/solr-operator/pull/509
https://github.com/apache/solr-operator/pull/455 introduced a bug for non-recurring backups that was unearthed while working on https://github.com/apache/solr-operator/pull/507
Basically we need to only update the `NextScheduledTimestamp` if `recurrence` is enabled.
I also restructured the logic to hopefully make it more clear when backup logic should be run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on a diff in pull request #509: Fix non-recurring backups
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on code in PR #509:
URL: https://github.com/apache/solr-operator/pull/509#discussion_r1056521056
##########
controllers/solrbackup_controller.go:
##########
@@ -146,7 +145,7 @@ func (r *SolrBackupReconciler) Reconcile(ctx context.Context, req ctrl.Request)
}
// Schedule the next backupTime, if it doesn't have a next scheduled time, it has recurrence and the current backup is finished
- if backup.Status.IndividualSolrBackupStatus.Finished {
+ if backup.Status.IndividualSolrBackupStatus.Finished && backup.Spec.Recurrence.IsEnabled() {
Review Comment:
[+1] Weird that the comment on L147 mentions recurrence-being-enabled as being a prereq, but we never checked for it before now. Must've just been an oversight on my part?
Anyway, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #509: Fix non-recurring backups
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #509:
URL: https://github.com/apache/solr-operator/pull/509#issuecomment-1364151186
> maybe next time we could put some of the more cosmetic improvements in their own commit, but it seems pretty harmless here.
Good call, just included since I was going mad trying to fix it so many ways before realizing that I wasn't testing the changes at all....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #509: Fix non-recurring backups
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #509:
URL: https://github.com/apache/solr-operator/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org