You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/14 21:06:35 UTC
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13014
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
[jenkins] fix collection of Java dist-test logs
Fixed the collection of logs from Java tests run via the dist-test
utility. Prior to this patch, all the logs were collided into a single
test-output.txt file.
This is a follow-up to the following changelists:
f5117d294a32ea9e4035bb4f8e9fb376dea68646
8c184e2a972729cbb026b6962d6bf558b86e9cf5
Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/13014/1
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 )
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13014/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
PS1:
> As a (cleaner?) alternative, how about renaming test-output.txt in run_dist
Yep, I also thought about that. It would be nice to get some input from Grant on this. Basically, I want to understand whether keeping that test-output.txt pattern was something crucial somewhere else in dist-testing Java test scenarios. Or that was the easiest way to go forward here?
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:46:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 )
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13014/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
PS1:
> Yep, I also thought about that. It would be nice to get some input from Gr
I don't think there is any specific reason it was named test-output.txt. It was likely just an easy default choice. Changing it should be fine.
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:52:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 )
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13014/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
PS1:
As a (cleaner?) alternative, how about renaming test-output.txt in run_dist_test.py? Looking at DistTestTask.java, the arguments to run_dist_test.py are:
// Build up the actual Java command line to run the test.
ImmutableList.Builder<String> cmd = new ImmutableList.Builder<>();
cmd.add(isolateFileDir.relativize(buildSupportDir.resolve("run_dist_test.py")).toString());
if (collectTmpDir) {
cmd.add("--collect-tmpdir");
}
cmd.add("--test-language=java",
"--",
"-ea",
"-cp",
Joiner.on(":").join(classpath));
for (Map.Entry<String, Object> e : test.getSystemProperties().entrySet()) {
cmd.add("-D" + e.getKey() + "=" + e.getValue());
}
cmd.add("-DkuduBinDir=" + isolateFileDir.relativize(binDir),
"org.junit.runner.JUnitCore",
testClass);
The last one looks like the test class to run. Maybe you can extract it in run_dist_test.py and use it to name the output file? Should also assert that it looks like a Java test class, in case someone changes the args. Or maybe just search through the args looking for org.apache.kudu (and assume that it's a prefix for a test class name).
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 15 Apr 2019 03:51:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [jenkins] fix collection of Java dist-test logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 )
Change subject: [jenkins] fix collection of Java dist-test logs
......................................................................
Patch Set 1: Verified+1
unrelated flake in HmsConfigurations/MasterFailoverTest.TestMasterPermanentFailure/0
--
To view, visit http://gerrit.cloudera.org:8080/13014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3b537e3592f768b0f14687aaadaa00444550f7
Gerrit-Change-Number: 13014
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 14 Apr 2019 21:53:45 +0000
Gerrit-HasComments: No