You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 10:49:57 UTC

[GitHub] [pulsar] cbornet opened a new pull request, #17142: [fix][function] Use the schema set by the Function when it returns a Record

cbornet opened a new pull request, #17142:
URL: https://github.com/apache/pulsar/pull/17142

   ### Motivation
   
   Currently the schema set by a Function returning a Record is not taken into account.
   
   ### Modifications
   
   Don't set the schema to the initialized Sink Schema if the record is a OutputRecordSinkRecord
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   * testGenericObjectRemoveFieldRecordFunction
   * testGenericObjectRemoveFieldRecordFunctionKeyValue
   
   ### Does this pull request potentially affect one of the following parts:
   
   no
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   it's a fix
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #17142: [fix][function] Use the schema set by the Function when it returns a Record

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17142:
URL: https://github.com/apache/pulsar/pull/17142#issuecomment-1217936604

   @cbornet Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli closed pull request #17142: [fix][function] Use the schema set by the Function when it returns a Record

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #17142: [fix][function] Use the schema set by the Function when it returns a Record
URL: https://github.com/apache/pulsar/pull/17142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #17142: [fix][function] Use the schema set by the Function when it returns a Record

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #17142:
URL: https://github.com/apache/pulsar/pull/17142#issuecomment-1218374102

   /pulsar-bot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #17142: [fix][function] Use the schema set by the Function when it returns a Record

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17142:
URL: https://github.com/apache/pulsar/pull/17142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org