You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/21 14:27:02 UTC
[GitHub] [skywalking] LIU-WEI-git opened a new issue #7527: A difference of IBrowserLogQueryDAO in storage plugins
LIU-WEI-git opened a new issue #7527:
URL: https://github.com/apache/skywalking/issues/7527
### Question
When viewing storage plugins, I find a relationship between them.
If H2 storage plugin use "order by" in the query statement, InfluxDB plugin will use "top" or "bottom" function in its implement.
But I find a difference of IBrowserLogQueryDAO in storage plugins.
- BrowserLogQuery.java in InfluxDB storage plugin: the query contains a sort function "top".
- H2BrowserLogQueryDAO.java in H2 storage plugin: the query doesn't contain "order by".
- BrowserLogQueryEsDAO.java and BrowserLogQueryEs7DAO.java in Elasticsearch storage plugin: the query doesn't contain "sort" function
Why this difference appears?
Is this difference a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7527: A difference of IBrowserLogQueryDAO in storage plugins
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7527:
URL: https://github.com/apache/skywalking/issues/7527#issuecomment-903127290
Basically, right now, we don't have `order by` in design, but from my understanding we should order by `TIMESTAMP`(desc) like the service log query.
Welcome to submit a pull request to polish this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shreelakshmijoshi commented on issue #7527: A difference of IBrowserLogQueryDAO in storage plugins
Posted by GitBox <gi...@apache.org>.
shreelakshmijoshi commented on issue #7527:
URL: https://github.com/apache/skywalking/issues/7527#issuecomment-903328811
Hi @wu-sheng !
I am a new open source contributor and would like to solve this issue, could you help me understand the issue better by providing some extra references ?
Is this is issue open to contribute ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7527: A difference of IBrowserLogQueryDAO in storage plugins
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7527:
URL: https://github.com/apache/skywalking/issues/7527#issuecomment-903347239
Yes, this is open to new contributors.
You could set pull request to add sort to those two missing DAOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal closed issue #7527: A difference of IBrowserLogQueryDAO in storage plugins
Posted by GitBox <gi...@apache.org>.
arugal closed issue #7527:
URL: https://github.com/apache/skywalking/issues/7527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org