You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "seongjinyoon (via GitHub)" <gi...@apache.org> on 2025/09/10 06:31:43 UTC
[PR] feat: enable dataset creation in export results window [texera]
seongjinyoon opened a new pull request, #3726:
URL: https://github.com/apache/texera/pull/3726
**Description:**
Allows users to create new datasets within the export results window
**Changes:**
- Added button in export results window that opens the dataset creation modal
- Fixed minor bug where dataset search filter did not properly reset when input is cleared
Closes #3615
https://github.com/user-attachments/assets/ee81e73f-52c8-4b63-b005-09711a6472e8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable dataset creation in export results window [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3726:
URL: https://github.com/apache/texera/pull/3726#discussion_r2335722797
##########
core/gui/src/app/workspace/component/result-exportation/result-exportation.component.html:
##########
@@ -89,34 +89,50 @@
</nz-row>
</form>
</div>
- <input
- *ngIf="destination === 'dataset'"
- [(ngModel)]="inputDatasetName"
- (input)="onUserInputDatasetName($event)"
- type="text"
- nz-input
- name="datasetName"
- placeholder="Search for dataset by name..."
- [nzAutocomplete]="auto" />
- <nz-autocomplete #auto>
- <nz-auto-option
- *ngFor="let dataset of filteredUserAccessibleDatasets"
- [nzLabel]="dataset.dataset.name">
- <div class="auto-option-content">
- <div class="dataset-id-container">{{dataset.dataset.did?.toString()}}</div>
+ <div
+ class="input-wrapper"
Review Comment:
You don't need class name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable dataset creation in export results window [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3726:
URL: https://github.com/apache/texera/pull/3726#discussion_r2335760772
##########
core/gui/src/app/workspace/component/result-exportation/result-exportation.component.html:
##########
@@ -89,34 +89,50 @@
</nz-row>
</form>
</div>
- <input
- *ngIf="destination === 'dataset'"
- [(ngModel)]="inputDatasetName"
- (input)="onUserInputDatasetName($event)"
- type="text"
- nz-input
- name="datasetName"
- placeholder="Search for dataset by name..."
- [nzAutocomplete]="auto" />
- <nz-autocomplete #auto>
- <nz-auto-option
- *ngFor="let dataset of filteredUserAccessibleDatasets"
- [nzLabel]="dataset.dataset.name">
- <div class="auto-option-content">
- <div class="dataset-id-container">{{dataset.dataset.did?.toString()}}</div>
+ <div
+ class="input-wrapper"
Review Comment:
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable dataset creation in export results window [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3726:
URL: https://github.com/apache/texera/pull/3726#discussion_r2335696441
##########
core/gui/src/app/workspace/component/result-exportation/result-exportation.component.ts:
##########
@@ -157,4 +161,24 @@ export class ResultExportationComponent implements OnInit {
);
this.modalRef.close();
}
+
+ onClickCreateNewDataset(): void {
+ const modal = this.modalService.create({
+ nzTitle: "Create New Dataset",
+ nzContent: UserDatasetVersionCreatorComponent,
+ nzData: {
+ isCreatingVersion: false,
+ },
+ nzFooter: null,
+ nzWidth: 500,
+ });
+
+ modal.afterClose.subscribe((result: DashboardDataset | null) => {
+ if (result) {
+ this.userAccessibleDatasets.unshift(result);
+ this.filteredUserAccessibleDatasets = [...this.userAccessibleDatasets];
+ this.inputDatasetName = result.dataset.name;
Review Comment:
Consider calling the existing `onUserInputDatasetName()` method instead of directly setting `inputDatasetName` to ensure consistent behavior with the search filtering logic.
```suggestion
this.inputDatasetName = result.dataset.name;
this.onUserInputDatasetName(null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable dataset creation in export results window [texera]
Posted by "seongjinyoon (via GitHub)" <gi...@apache.org>.
seongjinyoon commented on code in PR #3726:
URL: https://github.com/apache/texera/pull/3726#discussion_r2335730458
##########
core/gui/src/app/workspace/component/result-exportation/result-exportation.component.html:
##########
@@ -89,34 +89,50 @@
</nz-row>
</form>
</div>
- <input
- *ngIf="destination === 'dataset'"
- [(ngModel)]="inputDatasetName"
- (input)="onUserInputDatasetName($event)"
- type="text"
- nz-input
- name="datasetName"
- placeholder="Search for dataset by name..."
- [nzAutocomplete]="auto" />
- <nz-autocomplete #auto>
- <nz-auto-option
- *ngFor="let dataset of filteredUserAccessibleDatasets"
- [nzLabel]="dataset.dataset.name">
- <div class="auto-option-content">
- <div class="dataset-id-container">{{dataset.dataset.did?.toString()}}</div>
+ <div
+ class="input-wrapper"
Review Comment:
Without it, the modal looks like this
<img width="1154" height="776" alt="Screenshot 2025-09-09 at 11 48 40 PM" src="https://github.com/user-attachments/assets/e8bd3538-edc7-435d-b516-776252525e7c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable dataset creation in export results window [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #3726:
URL: https://github.com/apache/texera/pull/3726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org