You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/21 07:12:01 UTC

[GitHub] [flink] klion26 commented on a change in pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated

klion26 commented on a change in pull request #12189:
URL: https://github.com/apache/flink/pull/12189#discussion_r428476861



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
##########
@@ -219,31 +219,6 @@ public void dispose() {
 		return getListState(stateDescriptor, OperatorStateHandle.Mode.UNION);
 	}
 
-	// -------------------------------------------------------------------------------------------
-	//  Deprecated state access methods
-	// -------------------------------------------------------------------------------------------
-
-	/**
-	 * @deprecated This was deprecated as part of a refinement to the function names.
-	 *             Please use {@link #getListState(ListStateDescriptor)} instead.
-	 */
-	@Deprecated
-	@Override
-	public <S> ListState<S> getOperatorState(ListStateDescriptor<S> stateDescriptor) throws Exception {
-		return getListState(stateDescriptor);
-	}
-
-	/**
-	 * @deprecated Using Java serialization for persisting state is not encouraged.
-	 *             Please use {@link #getListState(ListStateDescriptor)} instead.
-	 */
-	@SuppressWarnings("unchecked")
-	@Deprecated
-	@Override
-	public <T extends Serializable> ListState<T> getSerializableListState(String stateName) throws Exception {

Review comment:
       Maybe we can add an auxiliary function in which the function implementation is same as this function so that we can migrate easily?
   The `getSerializableListState()` will always use `deprecatedDefaultJavaSerializer`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org