You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/20 03:49:26 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1799: fix regex & omit vars when no value

juzhiyuan opened a new pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   - [x] update Regex according to schema_def
   - [ ] omit vars field in Route when no value contained
   
   **Related issues**
   
   fix #1798 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit e7d9a751a8a4204dab69cf8358befbb2a006eeb5
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/607e70ec01aa3800070a4251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848836199


   duplicate with https://github.com/apache/apisix-dashboard/pull/1921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-834027756


   ping @moonming to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 89cf9bbfcb3b393163bc79ed05f450707a827684
   
   https://deploy-preview-1799--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822962535


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1799](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25eb60e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e19c960456730d107ac3be4cffa36ad07d9eecde?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e19c960) will **increase** coverage by `0.04%`.
   > The diff coverage is `78.37%`.
   
   > :exclamation: Current head 25eb60e differs from pull request most recent head 89cf9bb. Consider uploading reports for the commit 89cf9bb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1799      +/-   ##
   ==========================================
   + Coverage   71.92%   71.97%   +0.04%     
   ==========================================
     Files         125      125              
     Lines        2921     2951      +30     
     Branches      703      716      +13     
   ==========================================
   + Hits         2101     2124      +23     
   - Misses        820      827       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `71.97% <78.37%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `66.66% <ø> (ø)` | |
   | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `37.73% <ø> (ø)` | |
   | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | |
   | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | `33.33% <ø> (ø)` | |
   | [...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==) | `81.48% <ø> (ø)` | |
   | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.14% <75.00%> (-1.39%)` | :arrow_down: |
   | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
   | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | `72.35% <100.00%> (-0.11%)` | :arrow_down: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e19c960...89cf9bb](https://codecov.io/gh/apache/apisix-dashboard/pull/1799?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848547900


   I think i should be looking into this, as he is kinda busy i guess 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Firstsawyou commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848544147


   cc @juzhiyuan   The conflict needs to be resolved.
   Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit dd479b66f16353a61b4cf0bd72162b3e98acf943
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/6091187c569810000741c24b


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit e1de4a8a1cfa62f9256585bc0884c6a716b100a8
   
   https://deploy-preview-1799--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit dd479b66f16353a61b4cf0bd72162b3e98acf943
   
   https://deploy-preview-1799--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 552c2beee1ba3d4d1a214d045f93854ee0dbee89
   
   https://deploy-preview-1799--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 89cf9bbfcb3b393163bc79ed05f450707a827684
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/607e4f3fba463f0007bb36c2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#discussion_r616365871



##########
File path: web/src/pages/Route/locales/en-US.ts
##########
@@ -75,10 +75,9 @@ export default {
   'page.route.form.itemExtraMessage.domain':
     'Domain Name or IP, support for generic Domain Name, for example: *.test.com',
   'page.route.form.itemRulesPatternMessage.domain':
-    'Only letters, numbers and * are supported. * can only be at the beginning, and only single * is supported',
+    'Only letters, numbers and * are supported, but * needs to be at the beginning.',

Review comment:
       ```suggestion
       'Only letters, numbers, -,_ and * are supported, but * needs to be at the beginning.',
   ```

##########
File path: web/src/pages/Route/locales/zh-CN.ts
##########
@@ -74,10 +74,9 @@ export default {
   'page.route.form.itemLabel.redirectURI': '重定向路径',
   'page.route.form.itemExtraMessage.domain': '路由匹配的域名列表。支持泛域名,如:*.test.com',
   'page.route.form.itemRulesPatternMessage.domain':
-    '仅支持字母、数字和 * ,且 * 只能是在开头,支持单个 * ',
+    '仅支持字母、数字和 *,但 * 需要在开头位置。',

Review comment:
       ```suggestion
       '仅支持字母、数字、-、_和 *,但 * 需要在开头位置。',
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit b67ad5c55da93fff013faca9ae59a08518261149
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60923289661760000883269d


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this? as you have to change the test files again because of that refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.
   > 
   > ok, will fix today.
   
   okay sir
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848588118


   > cc @juzhiyuan The conflict needs to be resolved.
   > Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.
   
   ok, will fix today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-848600120


   > > cc @juzhiyuan The conflict needs to be resolved.
   > > Some users have repeatedly reported the bug of `regex`, we should fix it as soon as possible.
   > 
   > ok, will fix today.
   
   can i fix this? as you have to change the test files again because of that refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 552c2beee1ba3d4d1a214d045f93854ee0dbee89
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609a57156cb88e0008eab447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1799: fix regex & omit vars when no value

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1799:
URL: https://github.com/apache/apisix-dashboard/pull/1799#issuecomment-822952760


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit b67ad5c55da93fff013faca9ae59a08518261149
   
   https://deploy-preview-1799--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org