svnsync doesn't sync changed revprops

[Jani Averbach <ja...@jaa.iki.fi>]

Hello,

The svnsync tool doesn't sync changed revprops at the moment. I have't
followed so closely svn lately (sorry about that), so I could not find
if this is by design or not. But to me it looks like a bug.

Please see attached recipe.

BR, jani

-- 
Jani Averbach

Re: svnsync doesn't sync changed revprops

[Jani Averbach <ja...@jaa.iki.fi>]

On 2006-09-13 18:37-0400, Garrett Rooney wrote:
> 
> See, I don't think that makes sense.  "Pending revisions" to me
> implies revisions that have not yet been synced.  Changed revprops, by
> definition, are associated with previous revisions, and such
> intrinsically wouldn't be syncronized by that command.

Yes, but the command name isn't 'transfer-pending-revisions', it is
'synchronize'.  And to me 'synchronize A to B' means that after the
fact B has all the content of A.  This was the reason for my initial
confusion, and why I put it under sync.

BR, Jani

-- 
Jani Averbach

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svnsync doesn't sync changed revprops

[David Glasser <gl...@mit.edu>]

On 9/13/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> See, I don't think that makes sense.  "Pending revisions" to me
> implies revisions that have not yet been synced.  Changed revprops, by
> definition, are associated with previous revisions, and such
> intrinsically wouldn't be syncronized by that command.
>
> No argument that this should be documented someplace, but I'm not sure
> that's the right spot.  Or maybe it just needs to be phrased
> differently.

Yeah, I agree. Really, somebody needs to write an svnbook section.
http://svnbook.red-bean.com/trac/ticket/24 has some notes on that;
somebody with trac access could add a comment about copy-revprops.

But yeah, I could imagine something like a little DB that stores the
last time that revprops were changed on each revision, and a little
CGI that returns a list of revisions with revprops changed since a
given time, and a little script that asks the CGI for a list of
revisions and calls svnsync copy-revs. This would fit well into
contrib...

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svnsync doesn't sync changed revprops

[Garrett Rooney <ro...@electricjellyfish.net>]

On 9/13/06, Jani Averbach <ja...@jaa.iki.fi> wrote:
> On 2006-09-13 17:42-0400, Garrett Rooney wrote:
> >
> > It is not, in fact, a bug.  It is a limitation forced upon us by the
> > design of Subversion's revprops.
> >
>
> Very fair. How about attached patch?

See, I don't think that makes sense.  "Pending revisions" to me
implies revisions that have not yet been synced.  Changed revprops, by
definition, are associated with previous revisions, and such
intrinsically wouldn't be syncronized by that command.

No argument that this should be documented someplace, but I'm not sure
that's the right spot.  Or maybe it just needs to be phrased
differently.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svnsync doesn't sync changed revprops

[Jani Averbach <ja...@jaa.iki.fi>]

On 2006-09-13 17:42-0400, Garrett Rooney wrote:
> 
> It is not, in fact, a bug.  It is a limitation forced upon us by the
> design of Subversion's revprops.
> 

Very fair. How about attached patch?

BR, Jani

-- 
Jani Averbach

Re: svnsync doesn't sync changed revprops

[Garrett Rooney <ro...@electricjellyfish.net>]

On 9/13/06, Jani Averbach <ja...@jaa.iki.fi> wrote:
> Hello,
>
> The svnsync tool doesn't sync changed revprops at the moment. I have't
> followed so closely svn lately (sorry about that), so I could not find
> if this is by design or not. But to me it looks like a bug.

It is not, in fact, a bug.  It is a limitation forced upon us by the
design of Subversion's revprops.

There is no way to determine that a revprop has changed without
manually checking all of them, which would be a performance nightmare.
 If you want revprops to be changed you need to use a
post-revprop-change hook script to record that changes occurred, and
then later use the copy-revprops command in svnsync to do the copying.
 There's really nothing else that can be done without deep rooted
changes to how svn stores its revprops.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svnsync doesn't sync changed revprops

[David Glasser <gl...@mit.edu>]

On 9/13/06, Jani Averbach <ja...@jaa.iki.fi> wrote:
> The svnsync tool doesn't sync changed revprops at the moment. I have't
> followed so closely svn lately (sorry about that), so I could not find
> if this is by design or not. But to me it looks like a bug.

This is essentially by design. However, it comes with a subcommand to
sync revprops of explicit revisions, and you can't change old revprops
without passing through a pre-revprop-change hook anyway. Thus, it's a
Simple Matter Of Programming to make a post-revprop-change hook which
records which revprops are changed in a way that's accessible to the
mirroring user, and a cronjob to check it and run svnsync
copy-revprops.

I'm sure we'd be happy to include scripts in Subversion's contrib
section that help to automate that process!

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org