You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/07/30 08:52:01 UTC
Review Request 13055: Fix to select default vpc offering with internal lb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/
-----------------------------------------------------------
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
Bugs: CLOUDSTACK-3923
Repository: cloudstack-git
Description
-------
When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
fix is to select vpc offering with id=1
Diffs
-----
test/integration/smoke/test_internal_lb.py 0535d6a
test/integration/smoke/test_network_acl.py 4b3c1f7
Diff: https://reviews.apache.org/r/13055/diff/
Testing
-------
tested.
Thanks,
SrikanteswaraRao Talluri
Re: Review Request 13055: Fix to select default vpc offering with internal lb
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24214
-----------------------------------------------------------
Review 13055 PASSED the build test
The url of build cloudstack-master-with-patch #78 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/78/
- Jenkins Cloudstack.org
On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:51 a.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3923
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
>
> Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
>
> fix is to select vpc offering with id=1
>
>
> Diffs
> -----
>
> test/integration/smoke/test_internal_lb.py 0535d6a
> test/integration/smoke/test_network_acl.py 4b3c1f7
>
> Diff: https://reviews.apache.org/r/13055/diff/
>
>
> Testing
> -------
>
> tested.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request 13055: Fix to select default vpc offering with internal lb
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_internal_lb.py, line 116
> > <https://reviews.apache.org/r/13055/diff/1/?file=330476#file330476line116>
> >
> > we should not use the ids to list. How about list the vpcoffering based on the name? and then use the returned uuid.
Filtering it using 'isdefault=true'
> On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_network_acl.py, line 112
> > <https://reviews.apache.org/r/13055/diff/1/?file=330477#file330477line112>
> >
> > we should not use the ids to list. How about list the vpcoffering based on the name? and then use the returned uuid.
Filtering it using 'isdefault=true'
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24234
-----------------------------------------------------------
On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:51 a.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3923
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
>
> Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
>
> fix is to select vpc offering with id=1
>
>
> Diffs
> -----
>
> test/integration/smoke/test_internal_lb.py 0535d6a
> test/integration/smoke/test_network_acl.py 4b3c1f7
>
> Diff: https://reviews.apache.org/r/13055/diff/
>
>
> Testing
> -------
>
> tested.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request 13055: Fix to select default vpc offering with internal lb
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/#review24234
-----------------------------------------------------------
test/integration/smoke/test_internal_lb.py
<https://reviews.apache.org/r/13055/#comment48049>
we should not use the ids to list. How about list the vpcoffering based on the name? and then use the returned uuid.
test/integration/smoke/test_network_acl.py
<https://reviews.apache.org/r/13055/#comment48050>
we should not use the ids to list. How about list the vpcoffering based on the name? and then use the returned uuid.
- Prasanna Santhanam
On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13055/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:51 a.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3923
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
>
> Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
>
> fix is to select vpc offering with id=1
>
>
> Diffs
> -----
>
> test/integration/smoke/test_internal_lb.py 0535d6a
> test/integration/smoke/test_network_acl.py 4b3c1f7
>
> Diff: https://reviews.apache.org/r/13055/diff/
>
>
> Testing
> -------
>
> tested.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request 13055: Fix to select default vpc offering with internal lb
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/
-----------------------------------------------------------
(Updated July 30, 2013, 6:39 p.m.)
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
Changes
-------
uploaded final corrected diff file
Bugs: CLOUDSTACK-3923
Repository: cloudstack-git
Description
-------
When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
fix is to select vpc offering with id=1
Diffs (updated)
-----
test/integration/smoke/test_internal_lb.py 0535d6a
test/integration/smoke/test_network_acl.py 4b3c1f7
Diff: https://reviews.apache.org/r/13055/diff/
Testing
-------
tested.
Thanks,
SrikanteswaraRao Talluri
Re: Review Request 13055: Fix to select default vpc offering with internal lb
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13055/
-----------------------------------------------------------
(Updated July 30, 2013, 6:24 p.m.)
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
Changes
-------
Filtering it using 'isdefault=true'
Bugs: CLOUDSTACK-3923
Repository: cloudstack-git
Description
-------
When there are multiple VPC offerings, test is failing because list VPC offering is listing multiple vpc offerings.
Test requires to select the default VPC offering which has lb service as internal LB which has id=1.
fix is to select vpc offering with id=1
Diffs (updated)
-----
test/integration/smoke/test_internal_lb.py 0535d6a
test/integration/smoke/test_network_acl.py 4b3c1f7
Diff: https://reviews.apache.org/r/13055/diff/
Testing
-------
tested.
Thanks,
SrikanteswaraRao Talluri