Re: [PR] Keep an escaped value that equals the null string [commons-csv]

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #626:
URL: https://github.com/apache/commons-csv/pull/626#discussion_r3624495512


##########
src/test/java/org/apache/commons/csv/CSVParserTest.java:
##########
@@ -584,6 +584,22 @@ void testEndOfFileBehaviorExcel() throws Exception {
         }
     }
 
+    @Test
+    void testEscapedNullStringIsAValue() throws Exception {
+        // "\N" is the MySQL and PostgreSQL null marker, "\\N" is the value "\N", which is what the printer writes for it.
+        for (final CSVFormat format : new CSVFormat[] { CSVFormat.MYSQL, CSVFormat.POSTGRESQL_TEXT, CSVFormat.ORACLE }) {

Review Comment:
   Use a JUnit `@ParameterizeTest` instead of a loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org