You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2015/07/31 00:51:57 UTC
[1/2] jclouds git commit: Upgrade to error-prone 2.0.4
Repository: jclouds
Updated Branches:
refs/heads/master ba55ab4b1 -> d5357f76e
Upgrade to error-prone 2.0.4
Release notes:
https://groups.google.com/forum/#!topic/error-prone-announce/syl8dKP_Aow
https://groups.google.com/forum/#!topic/error-prone-announce/iZI0yixYDms
https://groups.google.com/forum/#!topic/error-prone-announce/v7aBgfhH-u8
https://groups.google.com/forum/#!topic/error-prone-announce/-f6Cv6jKvig
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/d5357f76
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/d5357f76
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/d5357f76
Branch: refs/heads/master
Commit: d5357f76e8ff452ab7274e5825d18063c1487153
Parents: 98b3105
Author: Andrew Gaul <ga...@apache.org>
Authored: Thu Jul 30 15:06:54 2015 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Thu Jul 30 15:40:03 2015 -0700
----------------------------------------------------------------------
project/pom.xml | 5 +++++
1 file changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d5357f76/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 6dfc1c8..b23a93f 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -759,6 +759,11 @@
<artifactId>plexus-compiler-javac-errorprone</artifactId>
<version>2.5</version>
</dependency>
+ <dependency>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>2.0.4</version>
+ </dependency>
</dependencies>
</plugin>
<plugin>
[2/2] jclouds git commit: Address error-prone errors
Posted by ga...@apache.org.
Address error-prone errors
Mostly of the form, Collection.size() >= 0.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/98b31056
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/98b31056
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/98b31056
Branch: refs/heads/master
Commit: 98b3105669fdff75f6fe5355bc83d049b400a152
Parents: ba55ab4
Author: Andrew Gaul <ga...@apache.org>
Authored: Thu Jul 30 15:21:42 2015 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Thu Jul 30 15:40:03 2015 -0700
----------------------------------------------------------------------
.../java/org/jclouds/cloudstack/features/AddressApiLiveTest.java | 2 +-
.../java/org/jclouds/cloudstack/features/EventApiLiveTest.java | 4 ++--
.../org/jclouds/cloudstack/features/FirewallApiLiveTest.java | 2 +-
.../org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java | 2 +-
.../org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java | 2 +-
.../java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java | 4 ++--
.../org/jclouds/cloudstack/features/HypervisorApiLiveTest.java | 2 +-
.../org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java | 2 +-
.../java/org/jclouds/cloudstack/features/NATApiLiveTest.java | 2 +-
.../jclouds/cloudstack/features/VirtualMachineApiLiveTest.java | 4 ++--
.../java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java | 4 ++--
.../openstack/nova/v2_0/compute/options/NovaTemplateOptions.java | 2 +-
.../openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java | 2 +-
.../cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java | 2 +-
.../cloudloadbalancers/v1/features/NodeApiLiveTest.java | 2 +-
.../org/jclouds/compute/internal/BaseComputeServiceLiveTest.java | 2 +-
.../org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java | 2 +-
.../java/org/jclouds/softlayer/features/AccountApiLiveTest.java | 2 +-
.../org/jclouds/softlayer/features/DatacenterApiLiveTest.java | 2 +-
.../softlayer/features/SoftwareDescriptionApiLiveTest.java | 2 +-
20 files changed, 24 insertions(+), 24 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java
index dc685a6..5b77c4a 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/AddressApiLiveTest.java
@@ -71,7 +71,7 @@ public class AddressApiLiveTest extends BaseCloudStackApiLiveTest {
return;
Set<PublicIPAddress> response = client.getAddressApi().listPublicIPAddresses();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (PublicIPAddress ip : response) {
PublicIPAddress newDetails = getOnlyElement(client.getAddressApi().listPublicIPAddresses(
ListPublicIPAddressesOptions.Builder.id(ip.getId())));
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java
index 2f4cdef..10086f9 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/EventApiLiveTest.java
@@ -33,7 +33,7 @@ public class EventApiLiveTest extends BaseCloudStackApiLiveTest {
public void testlistEventTypes() throws Exception {
final Set<String> response = client.getEventApi().listEventTypes();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (String type : response) {
checkEventType(type);
}
@@ -42,7 +42,7 @@ public class EventApiLiveTest extends BaseCloudStackApiLiveTest {
public void testlistEvents() throws Exception {
final Set<Event> response = client.getEventApi().listEvents();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (Event event : response) {
checkEvent(event);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java
index a96fad8..13269a7 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiLiveTest.java
@@ -115,7 +115,7 @@ public class FirewallApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListPortForwardingRules() throws Exception {
Set<PortForwardingRule> response = client.getFirewallApi().listPortForwardingRules();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (final PortForwardingRule rule : response) {
checkPortForwardingRule(rule);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java
index 84b4602..0efe232 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalAlertApiLiveTest.java
@@ -38,7 +38,7 @@ public class GlobalAlertApiLiveTest extends BaseCloudStackApiLiveTest {
final Set<Alert> response = globalAdminClient.getAlertClient().listAlerts();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
int count = 0;
for (Alert alert : response) {
assertNotNull(alert.getDescription());
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java
index 14e48e7..2770c34 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalUsageApiLiveTest.java
@@ -52,7 +52,7 @@ public class GlobalUsageApiLiveTest extends BaseCloudStackApiLiveTest {
Set<UsageRecord> records = globalAdminClient.getUsageClient().listUsageRecords(start, end, ListUsageRecordsOptions.NONE);
assertNotNull(records);
- assertTrue(records.size() >= 0);
+ assertTrue(records.size() > 0);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java
index 43c0d3a..d5afd7f 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GuestOSApiLiveTest.java
@@ -38,7 +38,7 @@ public class GuestOSApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListOSTypes() throws Exception {
Set<OSType> response = client.getGuestOSApi().listOSTypes();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (OSType type : response) {
OSType newDetails = getOnlyElement(client.getGuestOSApi().listOSTypes(
ListOSTypesOptions.Builder.id(type.getId())));
@@ -50,7 +50,7 @@ public class GuestOSApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListOSCategories() throws Exception {
Map<String, String> response = client.getGuestOSApi().listOSCategories();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (Entry<String, String> category : response.entrySet()) {
checkOSCategory(category);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java
index 13400fe..57c41ba 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/HypervisorApiLiveTest.java
@@ -33,7 +33,7 @@ public class HypervisorApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListHypervisors() throws Exception {
Set<String> response = client.getHypervisorApi().listHypervisors();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (Zone zone : client.getZoneApi().listZones()) {
Set<String> zoneHype = client.getHypervisorApi().listHypervisorsInZone(zone.getId());
assert response.containsAll(zoneHype);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java
index dbc624b..8a02b49 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/LoadBalancerApiLiveTest.java
@@ -191,7 +191,7 @@ public class LoadBalancerApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListLoadBalancerRules() throws Exception {
Set<LoadBalancerRule> response = client.getLoadBalancerApi().listLoadBalancerRules();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (LoadBalancerRule rule : response) {
LoadBalancerRule newDetails = findRuleWithId(rule.getId());
assertEquals(rule.getId(), newDetails.getId());
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java
index 2ecd4b6..583f3cf 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATApiLiveTest.java
@@ -38,7 +38,7 @@ public class NATApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListIPForwardingRules() throws Exception {
Set<IPForwardingRule> response = client.getNATApi().listIPForwardingRules();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (IPForwardingRule rule : response) {
IPForwardingRule newDetails = getOnlyElement(client.getNATApi().listIPForwardingRules(
ListIPForwardingRulesOptions.Builder.id(rule.getId())));
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java
index 81908af..e7c60b0 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/VirtualMachineApiLiveTest.java
@@ -335,7 +335,7 @@ public class VirtualMachineApiLiveTest extends BaseCloudStackApiLiveTest {
public void testListVirtualMachines() throws Exception {
Set<VirtualMachine> response = client.getVirtualMachineApi().listVirtualMachines();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (VirtualMachine vm : response) {
VirtualMachine newDetails = getOnlyElement(client.getVirtualMachineApi().listVirtualMachines(
ListVirtualMachinesOptions.Builder.id(vm.getId())));
@@ -392,7 +392,7 @@ public class VirtualMachineApiLiveTest extends BaseCloudStackApiLiveTest {
}
}
- assert vm.getSecurityGroups() != null && vm.getSecurityGroups().size() >= 0 : vm;
+ assert vm.getSecurityGroups() != null && vm.getSecurityGroups().size() > 0 : vm;
assert vm.getHypervisor() != null : vm;
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java
index ae1b480..fa0da5f 100644
--- a/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java
+++ b/apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiLiveTest.java
@@ -58,8 +58,8 @@ public class ZoneApiLiveTest extends BaseCloudStackApiLiveTest {
break;
case BASIC:
assert zone.getVLAN() == null : zone;
- assert zone.getDNS().size() >= 0 : zone;
- assert zone.getInternalDNS().size() >= 0 : zone;
+ assert zone.getDNS().size() > 0 : zone;
+ assert zone.getInternalDNS().size() > 0 : zone;
assert zone.getDomain() == null : zone;
assert zone.getDomainId() == null : zone;
assert zone.getGuestCIDRAddress() == null : zone;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java
----------------------------------------------------------------------
diff --git a/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java b/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java
index a6b1ed6..d8939ad 100644
--- a/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java
+++ b/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.java
@@ -113,7 +113,7 @@ public class NovaTemplateOptions extends TemplateOptions implements Cloneable {
@Override
public int hashCode() {
return Objects.hashCode(super.hashCode(), autoAssignFloatingIp, floatingIpPoolNames, generateKeyPair, keyPairName,
- userData, diskConfig, configDrive, novaNetworks, availabilityZone);
+ Arrays.hashCode(userData), diskConfig, configDrive, novaNetworks, availabilityZone);
}
@Override
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java
index 27eee5a..252091a 100644
--- a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java
+++ b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiLiveTest.java
@@ -50,7 +50,7 @@ public class FloatingIPApiLiveTest extends BaseNovaApiLiveTest {
FloatingIPApi api = apiOption.get();
Set<? extends FloatingIP> response = api.list().toSet();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (FloatingIP ip : response) {
FloatingIP newDetails = api.get(ip.getId());
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java b/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java
index cde046b..9cdea3e 100644
--- a/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java
+++ b/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/LoadBalancerApiLiveTest.java
@@ -109,7 +109,7 @@ public class LoadBalancerApiLiveTest extends BaseCloudLoadBalancersApiLiveTest {
Set<LoadBalancer> response = api.getLoadBalancerApi(region).list().concat().toSet();
assertNotNull(response);
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (LoadBalancer lb : response) {
if (!lbs.contains(lb))
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java b/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java
index c82898d..8dd8a9b 100644
--- a/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java
+++ b/apis/rackspace-cloudloadbalancers/src/test/java/org/jclouds/rackspace/cloudloadbalancers/v1/features/NodeApiLiveTest.java
@@ -107,7 +107,7 @@ public class NodeApiLiveTest extends BaseCloudLoadBalancersApiLiveTest {
for (LoadBalancer lb : nodes.keySet()) {
Set<Node> response = api.getNodeApi(lb.getRegion(), lb.getId()).list().concat().toSet();
assert null != response;
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (Node n : response) {
assert n.getId() != -1 : n;
assert n.getCondition() != null : n;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
----------------------------------------------------------------------
diff --git a/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java b/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
index 49033d2..f1af0b1 100644
--- a/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
+++ b/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java
@@ -844,7 +844,7 @@ public abstract class BaseComputeServiceLiveTest extends BaseComputeServiceConte
for (Hardware hardware : client.listHardwareProfiles()) {
assert hardware.getProviderId() != null : hardware;
assert getCores(hardware) > 0 : hardware;
- assert hardware.getVolumes().size() >= 0 : hardware;
+ assert hardware.getVolumes().size() > 0 : hardware;
assert hardware.getRam() > 0 : hardware;
assertEquals(hardware.getType(), ComputeType.HARDWARE);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java
----------------------------------------------------------------------
diff --git a/providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java b/providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java
index d6c6b14..e7d229c 100644
--- a/providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java
+++ b/providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSInstanceApiLiveTest.java
@@ -52,7 +52,7 @@ public class AWSInstanceApiLiveTest extends BaseComputeServiceContextLiveTest {
for (String region : view.unwrapApi(AWSEC2Api.class).getAvailabilityZoneAndRegionApi().get().describeRegions().keySet()) {
Set<? extends Reservation<? extends RunningInstance>> allResults = client.describeInstancesInRegion(region);
assertNotNull(allResults);
- assert allResults.size() >= 0 : allResults.size();
+ assert allResults.size() > 0 : allResults.size();
}
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java
----------------------------------------------------------------------
diff --git a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java
index c53fef4..6cc1b22 100644
--- a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java
+++ b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java
@@ -45,7 +45,7 @@ public class AccountApiLiveTest extends BaseSoftLayerApiLiveTest {
@Test
public void testListVirtualGuests() throws Exception {
Set<VirtualGuest> response = api().listVirtualGuests();
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (VirtualGuest vg : response) {
checkVirtualGuest(vg);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java
----------------------------------------------------------------------
diff --git a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java
index 0cf9338..6270129 100644
--- a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java
+++ b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java
@@ -39,7 +39,7 @@ public class DatacenterApiLiveTest extends BaseSoftLayerApiLiveTest {
public void testListDatacenters() {
Set<Datacenter> response = api().listDatacenters();
assertNotNull(response);
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
for (Datacenter vg : response) {
Datacenter newDetails = api().getDatacenter(vg.getId());
assertEquals(vg.getId(), newDetails.getId());
http://git-wip-us.apache.org/repos/asf/jclouds/blob/98b31056/providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java
----------------------------------------------------------------------
diff --git a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java
index 0948c6f..2ed5797 100644
--- a/providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java
+++ b/providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java
@@ -33,7 +33,7 @@ public class SoftwareDescriptionApiLiveTest extends BaseSoftLayerApiLiveTest {
public void testGetAllObjects() {
Set<SoftwareDescription> response = api().getAllObjects();
assertNotNull(response);
- assertTrue(response.size() >= 0);
+ assertTrue(response.size() > 0);
}
private SoftwareDescriptionApi api() {