You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/05 21:13:30 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #1487: SOLR-14426 Move top level classes to nested classes
madrob opened a new pull request #1487:
URL: https://github.com/apache/lucene-solr/pull/1487
https://issues.apache.org/jira/browse/SOLR-14426
This is as far as I could get before needing to give up. It was partly automated by IntelliJ but still painful manual in some respects. I think I got everything in the analytics module, and made a dent in core.
Probably want to view this comparison ignoring whitespace changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman removed a comment on pull request #1487: SOLR-14426 Move top level classes to nested classes
Posted by GitBox <gi...@apache.org>.
HoustonPutman removed a comment on pull request #1487:
URL: https://github.com/apache/lucene-solr/pull/1487#issuecomment-624345497
@uschindler have you seen this bug with other applications that use that plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman edited a comment on pull request #1487: SOLR-14426 Move top level classes to nested classes
Posted by GitBox <gi...@apache.org>.
HoustonPutman edited a comment on pull request #1487:
URL: https://github.com/apache/lucene-solr/pull/1487#issuecomment-624345348
This looks good to me. Didn't know those protected classes were so frowned upon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #1487: SOLR-14426 Move top level classes to nested classes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #1487:
URL: https://github.com/apache/lucene-solr/pull/1487#issuecomment-624345497
@uschindler have you seen this bug with other applications that use that plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #1487: SOLR-14426 Move top level classes to nested classes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #1487:
URL: https://github.com/apache/lucene-solr/pull/1487#issuecomment-624345348
This looks good to me. Kind of annoying that the gradle precommit plugin has this bug. I looked around in that repo to try and find something, but I couldn't find anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org