You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/03/01 03:05:38 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1289: [CELEBORN-354][Flink] fix map partition may return the wrong result
RexXiong opened a new pull request, #1289:
URL: https://github.com/apache/incubator-celeborn/pull/1289
…artitionIds
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
1.return lastSucceedPartitionIds when actually replay to current rpc context
2.remove shuffleSucceedPartitionIds when shuffle expired
### Why are the changes needed?
we may get updated shuffleSucceedPartitionIds by other thread while reducerFileGroupsMap.get the older file groups result(which may not contains newly finished partitions). So we need get the snapshot shuffleSucceedPartitionIds before
we return current reducerFileGroups of that shuffle. No need to lock here as currentHashMap will get the volatile result.
So reducerFileGroupsMap will get the newly current result when response.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
tpcds99 1T
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1289: [CELEBORN-354][Flink] fix map partition may return the wrong result
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1289:
URL: https://github.com/apache/incubator-celeborn/pull/1289#issuecomment-1449273312
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1289](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5195a44) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/7dc1ab13dbc5e4f07c198dfb68cebde646d1ee25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7dc1ab1) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1289 +/- ##
============================================
- Coverage 27.00% 26.99% -0.01%
- Complexity 821 823 +2
============================================
Files 218 218
Lines 18544 18540 -4
Branches 1998 1998
============================================
- Hits 5006 5003 -3
Misses 13210 13210
+ Partials 328 327 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...born/client/commit/MapPartitionCommitHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY2xpZW50L2NvbW1pdC9NYXBQYXJ0aXRpb25Db21taXRIYW5kbGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `81.17% <0.00%> (-0.01%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.93% <0.00%> (+1.36%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1289: [CELEBORN-354][Flink] fix map partition may return the wrong result
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1289:
URL: https://github.com/apache/incubator-celeborn/pull/1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org