You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/10/27 14:08:44 UTC
[GitHub] [incubator-doris] imay commented on a change in pull request #2075:
Segment v2 stream load core dump(#2037)
imay commented on a change in pull request #2075: Segment v2 stream load core dump(#2037)
URL: https://github.com/apache/incubator-doris/pull/2075#discussion_r339344334
##########
File path: be/src/olap/rowset/segment_v2/rle_page.h
##########
@@ -129,7 +124,26 @@ class RlePageBuilder : public PageBuilder {
(void)ret;
}
+ Slice finish_and_release() override {
+ return _finish(RELEASE);
+ }
+
private:
+
+ Slice _finish(BuilderReturnType builderReturnType) {
Review comment:
```suggestion
Slice _finish(BuilderReturnType type) {
```
In c++, we use lowercase and underline for variable names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org