You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/09/19 09:32:49 UTC
[GitHub] [kyuubi] zwangsheng opened a new pull request, #5310: [REST] RestService should wait jetty server started then start to recovery batch session
zwangsheng opened a new pull request, #5310:
URL: https://github.com/apache/kyuubi/pull/5310
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
In rare cases, when JettyServer is not fully started, we start the recovery task, will get the wrong port.
As a result, we cannot get the task that is not properly submitted by the current kyuubi server instance correctly.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5310: [REST] RestService should wait jetty server started then start to recovery batch session
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#discussion_r1329998851
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,10 +183,16 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
isStarted.set(true)
startBatchChecker()
startInternal()
+ // block until the HTTP server is started, otherwise, we may get
+ // the wrong HTTP server port -1
+ while (server.getState != "STARTED") {
+ debug(s"Wait for $getName server start")
Review Comment:
```suggestion
info(s"Waiting for $getName's HTTP server getting started")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5310: [BATCH] Batch session recovery should start after HTTP server getting started
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#issuecomment-1726810552
Thanks, merged to master/1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5310: [REST] RestService should wait jetty server started then start to recovery batch session
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#discussion_r1329997489
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,10 +183,16 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
isStarted.set(true)
startBatchChecker()
startInternal()
+ // if the server is not started, we should wait for it to start
+ // otherwise, we may get wrong server port with default -1
Review Comment:
```suggestion
// block until the HTTP server is started, otherwise, we may get
// the wrong HTTP server port -1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5310: [REST] RestService should wait jetty server started then start to recovery batch session
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#discussion_r1329849697
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,7 +191,14 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
Review Comment:
will move it to behind `startInternal()` solve the issue?
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,7 +191,14 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
Review Comment:
will move it behind `startInternal()` solve the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5310: [REST] RestService should wait jetty server started then start to recovery batch session
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#discussion_r1329849697
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -183,7 +191,14 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
if (!isStarted.get) {
try {
server.start()
- recoverBatchSessions()
Review Comment:
will moving it behind `startInternal()` solve the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5310: [BATCH] Batch session recovery should start after HTTP server getting started
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#issuecomment-1725546740
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5310](https://app.codecov.io/gh/apache/kyuubi/pull/5310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (15282c6) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/2abceeaf50d792b616d5ed4cb2608e30f9ace863?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2abceea) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #5310 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 590 590
Lines 33372 33376 +4
Branches 4415 4416 +1
======================================
- Misses 33372 33376 +4
```
| [Files Changed](https://app.codecov.io/gh/apache/kyuubi/pull/5310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/server/KyuubiRestFrontendService.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...cala/org/apache/kyuubi/server/ui/JettyServer.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvdWkvSmV0dHlTZXJ2ZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #5310: [BATCH] Batch session recovery should start after HTTP server getting started
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5310: [BATCH] Batch session recovery should start after HTTP server getting started
URL: https://github.com/apache/kyuubi/pull/5310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5310: [BATCH] Batch session recovery should start after HTTP server getting started
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5310:
URL: https://github.com/apache/kyuubi/pull/5310#issuecomment-1725375599
Also cc @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org