You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/14 02:37:03 UTC

[GitHub] [airflow] dstandish commented on pull request #26376: Add dataset event timestamp to dataset dag run queue

dstandish commented on PR #26376:
URL: https://github.com/apache/airflow/pull/26376#issuecomment-1246157844

   > Overall looks okay. I do wonder if instead we should pass down the event itself instead. I could see custom manager classes wanting the dataset itself, so passing the event makes the api pretty clean?
   
   The thing about that, though, is that these methods are all private anyway, not part of the public API... So users should not implement them anyway right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org