[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1350: MINIFICPP-1857 Create ListenTCP processor

[GitBox <gi...@apache.org>]

martinzink commented on code in PR #1350:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1350#discussion_r898986178


##########
extensions/standard-processors/processors/ListenTCP.h:
##########
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <string>
+
+#include "NetworkListenerProcessor.h"
+#include "core/logging/LoggerConfiguration.h"
+
+namespace org::apache::nifi::minifi::processors {
+
+class ListenTCP : public NetworkListenerProcessor {
+ public:
+  explicit ListenTCP(const std::string& name, const utils::Identifier& uuid = {})
+    : NetworkListenerProcessor(name, uuid, core::logging::LoggerFactory<ListenTCP>::getLogger()) {
+  }
+  ListenTCP(const ListenTCP&) = delete;
+  ListenTCP(ListenTCP&&) = delete;
+  ListenTCP& operator=(const ListenTCP&) = delete;
+  ListenTCP& operator=(ListenTCP&&) = delete;
+
+  EXTENSIONAPI static constexpr const char* Description = "Listens for Syslog messages being sent to a given port over TCP or UDP. "
+      "Incoming messages are optionally checked against regular expressions for RFC5424 and RFC3164 formatted messages. "
+      "With parsing enabled the individual parts of the message will be placed as FlowFile attributes and "
+      "valid messages will be transferred to success relationship, while invalid messages will be transferred to invalid relationship. "
+      "With parsing disabled all message will be routed to the success relationship, but it will only contain the sender, protocol, and port attributes";

Review Comment:
   This should be updated to the ListenTCP description like in PROCESSORS.md



##########
libminifi/src/utils/net/TcpServer.cpp:
##########
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "utils/net/TcpServer.h"
+
+namespace org::apache::nifi::minifi::utils::net {
+
+TcpSession::TcpSession(asio::io_context& io_context, utils::ConcurrentQueue<Message>& concurrent_queue, std::optional<size_t> max_queue_size, std::shared_ptr<core::logging::Logger> logger)
+  : concurrent_queue_(concurrent_queue),
+    max_queue_size_(max_queue_size),
+    socket_(io_context),
+    logger_(std::move(logger)) {
+}
+
+asio::ip::tcp::socket& TcpSession::getSocket() {
+  return socket_;
+}
+
+void TcpSession::start() {
+  asio::async_read_until(socket_,
+                         buffer_,
+                         '\n',
+                         [self = shared_from_this()](const auto& error_code, size_t) -> void {
+                           self->handleReadUntilNewLine(error_code);
+                         });
+}
+
+void TcpSession::handleReadUntilNewLine(std::error_code error_code) {
+  if (error_code)
+    return;
+  std::istream is(&buffer_);
+  std::string message;
+  std::getline(is, message);
+  if (!max_queue_size_ || max_queue_size_ > concurrent_queue_.size())
+    concurrent_queue_.enqueue(Message(message, Protocol::TCP, socket_.remote_endpoint().address(), socket_.local_endpoint().port()));
+  else
+    logger_->log_warn("Queue is full. Syslog message ignored.");

Review Comment:
   Since it is not a syslog specific class, this and the other warning in UDP server should probably just says TCP/UDP message ignored. 



##########
docker/test/integration/features/network_listener.feature:
##########
@@ -0,0 +1,14 @@
+Feature: Minifi C++ can act as a syslog listener

Review Comment:
   ```suggestion
   Feature: Minifi C++ can act as a TCP listener
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org