You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/04/14 15:45:19 UTC
[GitHub] [ratis] bharatviswa504 opened a new pull request #460: RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader …
bharatviswa504 opened a new pull request #460:
URL: https://github.com/apache/ratis/pull/460
…info missing.
## What changes were proposed in this pull request?
Use when raftconf does not have any peer info, use leader info from InstallSnapshotRequestProto.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1356
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
Updated test to not pass peer info during raft server star in raftgroup.
Also tested SCM-HA with fix now installSnapshot which happens during setConf is getting correct leaderInfo, previously used to get "".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] bshashikant commented on pull request #460: RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader …
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #460:
URL: https://github.com/apache/ratis/pull/460#issuecomment-822363489
The test failures are not related and will be addressed in a new PR. Merging this as this is required for SCM HA in https://github.com/apache/ozone/pull/2155.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] bshashikant merged pull request #460: RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader …
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #460:
URL: https://github.com/apache/ratis/pull/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] bharatviswa504 commented on pull request #460: RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader …
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #460:
URL: https://github.com/apache/ratis/pull/460#issuecomment-822362313
Opened a new Jira
https://issues.apache.org/jira/browse/RATIS-1359
to fix flaky tests.
As these failures are seen in other PR runs also.
https://github.com/apache/ratis/runs/2329275686#step:5:5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] bharatviswa504 commented on pull request #460: RATIS-1356. NotifyInstallSnapshot during SetConfiguration has leader …
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #460:
URL: https://github.com/apache/ratis/pull/460#issuecomment-822167324
Fixed CI. Test failing in CI, is passing locally.
![Uploading Screen Shot 2021-04-19 at 10.32.50 AM.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org