[jira] [Commented] (OAK-6579) Define how the counter index works in a composite setup

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189517#comment-16189517 ] 

Thomas Mueller commented on OAK-6579:
-------------------------------------

> I was thinking about the counter and counterOld idea - I think it'd be more useful if the new implementation changed the indexing data structure / format.

Yes, "new" and "old" is often used if the format is changed. Here, the reason is different, and would be purely for:

* In case we detect a bug (that affects the normal case, that is without mounts), we wouldn't need to immediately provide a patch - instead, we can simply switch to "counterOld".
* In case we suspect there is a bug, we can switch to "counterOld" and more easily analyze if it's really a bug.

>  I'm not sure if this redundancy (and 2x as much code to maintain) is desirable

We could immediately mark "counterOld" as deprecated. There is no need to maintain this old code.

> changes are also present in the NodeCounter

For that, it would probably make sense to be able to use the old code, for example using a boolean system property to switch to the old code.

If there _is_ a problem with the new code, then it surely is detected in Oak 1.8.x. So the old code can be removed afterwards.

> Define how the counter index works in a composite setup
> -------------------------------------------------------
>
>                 Key: OAK-6579
>                 URL: https://issues.apache.org/jira/browse/OAK-6579
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: composite, indexing
>            Reporter: Robert Munteanu
>            Assignee: Tomek Rękawek
>             Fix For: 1.8, 1.7.9
>
>         Attachments: OAK-6579-2.patch, OAK-6579.patch
>
>
> We need to see if this index can or should be adjusted to work in a composite environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)