You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/30 08:17:30 UTC
[GitHub] [rocketmq-clients] Lmonster opened a new pull request, #336: add error handling in simple consumer in golang
Lmonster opened a new pull request, #336:
URL: https://github.com/apache/rocketmq-clients/pull/336
Add error handling in simple consumer in golang for Subscribe and Unsubscribe when getting available message queue from server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336#issuecomment-1370470641
Thanks, @Lmonster !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] Lmonster commented on a diff in pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
Lmonster commented on code in PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336#discussion_r1061112688
##########
golang/simple_consumer.go:
##########
@@ -142,7 +146,11 @@ func (sc *defaultSimpleConsumer) Subscribe(topic string, filterExpression *Filte
}
func (sc *defaultSimpleConsumer) Unsubscribe(topic string) error {
- sc.cli.getMessageQueues(context.Background(), topic)
Review Comment:
it makes sense, i'll update it with this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] Lmonster commented on a diff in pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
Lmonster commented on code in PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336#discussion_r1061114839
##########
golang/simple_consumer.go:
##########
@@ -142,7 +146,11 @@ func (sc *defaultSimpleConsumer) Subscribe(topic string, filterExpression *Filte
}
func (sc *defaultSimpleConsumer) Unsubscribe(topic string) error {
- sc.cli.getMessageQueues(context.Background(), topic)
Review Comment:
> Getting message queues is redundant for topic unsubscription?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336#issuecomment-1367803900
# [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#336](https://codecov.io/gh/apache/rocketmq-clients/pull/336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b4a8d1) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/0464fe95595b17b74dba6bff2e1862d7bcd18313?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0464fe9) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #336 +/- ##
============================================
- Coverage 34.62% 34.59% -0.03%
Complexity 660 660
============================================
Files 220 220
Lines 11493 11501 +8
Branches 277 277
============================================
Hits 3979 3979
- Misses 7259 7267 +8
Partials 255 255
```
| Flag | Coverage Δ | |
|---|---|---|
| golang | `35.07% <0.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [golang/simple\_consumer.go](https://codecov.io/gh/apache/rocketmq-clients/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29sYW5nL3NpbXBsZV9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #336: golang: add error handling in simple consumer
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #336:
URL: https://github.com/apache/rocketmq-clients/pull/336#discussion_r1061090524
##########
golang/simple_consumer.go:
##########
@@ -142,7 +146,11 @@ func (sc *defaultSimpleConsumer) Subscribe(topic string, filterExpression *Filte
}
func (sc *defaultSimpleConsumer) Unsubscribe(topic string) error {
- sc.cli.getMessageQueues(context.Background(), topic)
Review Comment:
Getting message queues is redundant for topic unsubscription?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org