You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/07/04 08:59:30 UTC
[jira] Closed: (HARMONY-458) Simplification of module build.xml
files
[ http://issues.apache.org/jira/browse/HARMONY-458?page=all ]
Mark Hindess closed HARMONY-458:
--------------------------------
Resolution: Fixed
Assign To: Mark Hindess
This has been done now as part of my build.xml cleanup.
> Simplification of module build.xml files
> ----------------------------------------
>
> Key: HARMONY-458
> URL: http://issues.apache.org/jira/browse/HARMONY-458
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: 01.build.xml.simplification.sh, 02.build.xml.simplification.20060516.diff, 02.build.xml.simplification.diff
>
> Looking at the logs, we've been making lots of changes to modules/*/make/common/build.xml files but hardly any changes to modules/*/make/build.xml files. This made me wonder what this extra layer was adding and whether it was really being used as intended.
> The "common" and "platform" distinction is confusing since the template in luni uses "platform" to mean "natives". And the auth module that has platform code just builds it using the javac in the "common" build.xml. I can't really see much to be gained by splitting "common" and "platform" (in auth, for example); I think it would be just result in a lot of duplication.
> I've had a go at removing this extra layer. The result removes ~2000 lines of build files and I think it makes it easier to see what is going on. The resulting module build.xml files are only ~150 lines long
> and I don't think adding native build rules to these will make them unmanageably large so I think we should stick to one build.xml file for that too.
> I'll attach a patch and script with this simplification.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira