You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/02 18:55:34 UTC

Review Request 62733: Organized configuration documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.


Repository: mesos


Description
-------

This splits `docs/configuration.md` into the `docs/configuration`
folder. The documentation had grown too large, and so with
`configuration.md` becoming a table of contents, the discoverability of
the various runtime and build configurations is improved.


Diffs
-----

  docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
  docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
  docs/cmake.md PRE-CREATION 
  docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
  docs/configuration/agent.md PRE-CREATION 
  docs/configuration/autotools.md PRE-CREATION 
  docs/configuration/cmake.md PRE-CREATION 
  docs/configuration/libprocess.md PRE-CREATION 
  docs/configuration/master-and-agent.md PRE-CREATION 
  docs/configuration/master.md PRE-CREATION 
  docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
  docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
  docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
  docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
  docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
  docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 


Diff: https://reviews.apache.org/r/62733/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 62733: Organized configuration documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/#review187210
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62729.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62729`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733

Relevant logs:

- [apply-review-62729-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733/logs/apply-review-62729-stdout.log):

```
error: patch failed: 3rdparty/cmake/External.cmake:19
error: 3rdparty/cmake/External.cmake: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 5, 2017, 7:01 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62733/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 7:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This splits `docs/configuration.md` into the `docs/configuration`
> folder. The documentation had grown too large, and so with
> `configuration.md` becoming a table of contents, the discoverability of
> the various runtime and build configurations is improved.
> 
> 
> Diffs
> -----
> 
>   docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
>   docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/configuration/agent.md PRE-CREATION 
>   docs/configuration/autotools.md PRE-CREATION 
>   docs/configuration/cmake.md PRE-CREATION 
>   docs/configuration/libprocess.md PRE-CREATION 
>   docs/configuration/master-and-agent.md PRE-CREATION 
>   docs/configuration/master.md PRE-CREATION 
>   docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
>   docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
>   docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
>   docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
>   docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 
> 
> 
> Diff: https://reviews.apache.org/r/62733/diff/2/
> 
> 
> Testing
> -------
> 
> Verified the generated site works properly with the refactor.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 62733: Organized configuration documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/#review187211
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62729.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62729`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733

Relevant logs:

- [apply-review-62729-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733/logs/apply-review-62729-stdout.log):

```
error: patch failed: 3rdparty/cmake/External.cmake:19
error: 3rdparty/cmake/External.cmake: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 5, 2017, 7:01 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62733/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 7:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This splits `docs/configuration.md` into the `docs/configuration`
> folder. The documentation had grown too large, and so with
> `configuration.md` becoming a table of contents, the discoverability of
> the various runtime and build configurations is improved.
> 
> 
> Diffs
> -----
> 
>   docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
>   docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/configuration/agent.md PRE-CREATION 
>   docs/configuration/autotools.md PRE-CREATION 
>   docs/configuration/cmake.md PRE-CREATION 
>   docs/configuration/libprocess.md PRE-CREATION 
>   docs/configuration/master-and-agent.md PRE-CREATION 
>   docs/configuration/master.md PRE-CREATION 
>   docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
>   docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
>   docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
>   docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
>   docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 
> 
> 
> Diff: https://reviews.apache.org/r/62733/diff/2/
> 
> 
> Testing
> -------
> 
> Verified the generated site works properly with the refactor.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 62733: Organized configuration documentation.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/#review187683
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On Oct. 5, 2017, 12:01 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62733/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 12:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This splits `docs/configuration.md` into the `docs/configuration`
> folder. The documentation had grown too large, and so with
> `configuration.md` becoming a table of contents, the discoverability of
> the various runtime and build configurations is improved.
> 
> 
> Diffs
> -----
> 
>   docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
>   docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/configuration/agent.md PRE-CREATION 
>   docs/configuration/autotools.md PRE-CREATION 
>   docs/configuration/cmake.md PRE-CREATION 
>   docs/configuration/libprocess.md PRE-CREATION 
>   docs/configuration/master-and-agent.md PRE-CREATION 
>   docs/configuration/master.md PRE-CREATION 
>   docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
>   docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
>   docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
>   docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
>   docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 
> 
> 
> Diff: https://reviews.apache.org/r/62733/diff/2/
> 
> 
> Testing
> -------
> 
> Verified the generated site works properly with the refactor.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 62733: Organized configuration documentation.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/
-----------------------------------------------------------

(Updated Oct. 5, 2017, 12:01 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.


Changes
-------

Rebased.


Repository: mesos


Description
-------

This splits `docs/configuration.md` into the `docs/configuration`
folder. The documentation had grown too large, and so with
`configuration.md` becoming a table of contents, the discoverability of
the various runtime and build configurations is improved.


Diffs (updated)
-----

  docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
  docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
  docs/cmake.md PRE-CREATION 
  docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
  docs/configuration/agent.md PRE-CREATION 
  docs/configuration/autotools.md PRE-CREATION 
  docs/configuration/cmake.md PRE-CREATION 
  docs/configuration/libprocess.md PRE-CREATION 
  docs/configuration/master-and-agent.md PRE-CREATION 
  docs/configuration/master.md PRE-CREATION 
  docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
  docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
  docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
  docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
  docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
  docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 


Diff: https://reviews.apache.org/r/62733/diff/2/

Changes: https://reviews.apache.org/r/62733/diff/1-2/


Testing
-------

Verified the generated site works properly with the refactor.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 62733: Organized configuration documentation.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/
-----------------------------------------------------------

(Updated Oct. 3, 2017, 4:20 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.


Repository: mesos


Description
-------

This splits `docs/configuration.md` into the `docs/configuration`
folder. The documentation had grown too large, and so with
`configuration.md` becoming a table of contents, the discoverability of
the various runtime and build configurations is improved.


Diffs
-----

  docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
  docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
  docs/cmake.md PRE-CREATION 
  docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
  docs/configuration/agent.md PRE-CREATION 
  docs/configuration/autotools.md PRE-CREATION 
  docs/configuration/cmake.md PRE-CREATION 
  docs/configuration/libprocess.md PRE-CREATION 
  docs/configuration/master-and-agent.md PRE-CREATION 
  docs/configuration/master.md PRE-CREATION 
  docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
  docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
  docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
  docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
  docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
  docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 


Diff: https://reviews.apache.org/r/62733/diff/1/


Testing (updated)
-------

Verified the generated site works properly with the refactor.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 62733: Organized configuration documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/#review186869
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62730.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62730`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733

Relevant logs:

- [apply-review-62730-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62733/logs/apply-review-62730-stdout.log):

```
error: patch failed: cmake/CompilationConfigure.cmake:88
error: cmake/CompilationConfigure.cmake: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 2, 2017, 11:55 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62733/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This splits `docs/configuration.md` into the `docs/configuration`
> folder. The documentation had grown too large, and so with
> `configuration.md` becoming a table of contents, the discoverability of
> the various runtime and build configurations is improved.
> 
> 
> Diffs
> -----
> 
>   docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
>   docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/configuration/agent.md PRE-CREATION 
>   docs/configuration/autotools.md PRE-CREATION 
>   docs/configuration/cmake.md PRE-CREATION 
>   docs/configuration/libprocess.md PRE-CREATION 
>   docs/configuration/master-and-agent.md PRE-CREATION 
>   docs/configuration/master.md PRE-CREATION 
>   docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
>   docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
>   docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
>   docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
>   docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 
> 
> 
> Diff: https://reviews.apache.org/r/62733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 62733: Organized configuration documentation.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62733/#review186930
-----------------------------------------------------------



Bad patch!

Reviews applied: [62733, 62732, 62731, 62730, 62729]

Failed command: python support/apply-reviews.py -n -r 62732

Error:
2017-10-03 05:40:20 URL:https://reviews.apache.org/r/62732/diff/raw/ [41675/41675] -> "62732.patch" [1]
62732.patch:274: trailing whitespace.
 
error: patch failed: docs/configuration-cmake.md:1
error: docs/configuration-cmake.md: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19654/console

- Mesos Reviewbot


On Oct. 2, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62733/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James Peach, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This splits `docs/configuration.md` into the `docs/configuration`
> folder. The documentation had grown too large, and so with
> `configuration.md` becoming a table of contents, the discoverability of
> the various runtime and build configurations is improved.
> 
> 
> Diffs
> -----
> 
>   docs/agent-recovery.md f8f9cae87a7d6f4888b44014f1e907a2d0f3cfc7 
>   docs/authorization.md da51e8bad274ad9c480246782d9d810198713e6d 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/configuration/agent.md PRE-CREATION 
>   docs/configuration/autotools.md PRE-CREATION 
>   docs/configuration/cmake.md PRE-CREATION 
>   docs/configuration/libprocess.md PRE-CREATION 
>   docs/configuration/master-and-agent.md PRE-CREATION 
>   docs/configuration/master.md PRE-CREATION 
>   docs/container-image.md 74bf7bed5dfa5f5ecf8c384286001f68d33c376c 
>   docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c 
>   docs/fetcher.md 55d243540785a66640184a4775db5f6db240ab4f 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
>   docs/logging.md 84d54bf85d5d0e6da737c1f3854001f0c1e52409 
>   docs/sandbox.md 233eb1c90f33813f2b4673773823ec181dd25c9a 
> 
> 
> Diff: https://reviews.apache.org/r/62733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>