You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/30 09:15:50 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #18069: Fix #18064, check illegal value
azexcy opened a new pull request, #18069:
URL: https://github.com/apache/shardingsphere/pull/18069
Changes proposed in this pull request:
- check illegal value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#issuecomment-1140971023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18069](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b29e84) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a159040ed39eb26838fc236f1e99c8ff22c4f336?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a159040) will **decrease** coverage by `0.00%`.
> The diff coverage is `43.75%`.
> :exclamation: Current head 1b29e84 differs from pull request most recent head 1228ab7. Consider uploading reports for the commit 1228ab7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #18069 +/- ##
============================================
- Coverage 58.94% 58.94% -0.01%
- Complexity 2152 2153 +1
============================================
Files 3671 3671
Lines 54124 54164 +40
Branches 9185 9204 +19
============================================
+ Hits 31903 31925 +22
- Misses 19515 19525 +10
- Partials 2706 2714 +8
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stgresql/ingest/wal/decode/TestDecodingPlugin.java](https://codecov.io/gh/apache/shardingsphere/pull/18069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9wb3N0Z3Jlc3FsL2luZ2VzdC93YWwvZGVjb2RlL1Rlc3REZWNvZGluZ1BsdWdpbi5qYXZh) | `69.29% <6.66%> (-4.66%)` | :arrow_down: |
| [...ddl/impl/ShardingCreateViewStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/18069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZVZpZXdTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `62.85% <60.60%> (+62.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a159040...1228ab7](https://codecov.io/gh/apache/shardingsphere/pull/18069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
azexcy commented on code in PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#discussion_r885229507
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java:
##########
@@ -153,36 +155,46 @@ private String readColumnType(final ByteBuffer data) {
}
private Object readColumnData(final ByteBuffer data, final String columnType) {
- if (columnType.startsWith("numeric")) {
- return new BigDecimal(readNextSegment(data));
- }
if (columnType.startsWith("bit") || columnType.startsWith("bit varying")) {
return readNextSegment(data);
}
Review Comment:
Yes, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
azexcy commented on PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#issuecomment-1141129243
PostgerSQL TextDecoder:
```
table public.t_order_1: INSERT: order_id[bigint]:11 user_id[integer]:1 status[character varying]:'ok' timestp[timestamp without time zone]:null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#discussion_r885216839
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java:
##########
@@ -153,36 +155,46 @@ private String readColumnType(final ByteBuffer data) {
}
private Object readColumnData(final ByteBuffer data, final String columnType) {
- if (columnType.startsWith("numeric")) {
- return new BigDecimal(readNextSegment(data));
- }
if (columnType.startsWith("bit") || columnType.startsWith("bit varying")) {
return readNextSegment(data);
}
Review Comment:
Does "bit" and "bit varying" need to do the same change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
azexcy commented on PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#issuecomment-1141719053
Closed,because #18084 fixed same problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy closed pull request #18069: Fix #18064, check illegal value
Posted by GitBox <gi...@apache.org>.
azexcy closed pull request #18069: Fix #18064, check illegal value
URL: https://github.com/apache/shardingsphere/pull/18069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org