[jira] [Commented] (HBASE-7055) port HBASE-6371 tier-based compaction from 0.89-fb to trunk (with changes)

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652522#comment-13652522 ] 

stack commented on HBASE-7055:
------------------------------

What does this mean:

{code}
+  /** Min Flush time in FileInfo. That is the earliest time that a subset of the data
+   * in the file was flushed.
{code}

Isn't all data in a storefile flushed at the same time?  Or is this something else?  And what is the subset we are referring to here?

Is this flush time the earliest flush time of a group of compacted filess?

Previous -1 was special flush time but now MAX_VALUE is special initializer:

{code}
+    long minFlushTime = Long.MAX_VALUE;
{code}

Is there going to be conflict?  Should it be NO_MIN_FLUSH_TIME here instead of MAX_VALUE?

I got about 1/3rd through and then my eyes started to glaze over.  Will come back for a better review.  Patch is looking good.

This feature has to have doc before or just after it goes in. My sense is no one will use is though just because it so complicated requiring so much operator interjection and study.  I like the way though that the pluggable compactions allows stuff like this to exist w/o requiring our pulling the compaction code all over the place.





                
> port HBASE-6371 tier-based compaction from 0.89-fb to trunk (with changes)
> --------------------------------------------------------------------------
>
>                 Key: HBASE-7055
>                 URL: https://issues.apache.org/jira/browse/HBASE-7055
>             Project: HBase
>          Issue Type: Task
>          Components: Compaction
>    Affects Versions: 0.95.2
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.95.1
>
>         Attachments: HBASE-6371-squashed.patch, HBASE-6371-v2-squashed.patch, HBASE-6371-v3-refactor-only-squashed.patch, HBASE-6371-v4-refactor-only-squashed.patch, HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7055-v0.patch, HBASE-7055-v1.patch, HBASE-7055-v2.patch, HBASE-7055-v3.patch, HBASE-7055-v4.patch, HBASE-7055-v5.patch, HBASE-7055-v6.patch, HBASE-7055-v7.patch, HBASE-7055-v7.patch
>
>
> See HBASE-6371 for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira