You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2023/06/04 04:28:58 UTC
[GitHub] [doris] HappenLee commented on a diff in pull request #20298: [Enchancement](Agg State) storage function name and result is nullable in agg state type
HappenLee commented on code in PR #20298:
URL: https://github.com/apache/doris/pull/20298#discussion_r1216163047
##########
gensrc/thrift/Descriptors.thrift:
##########
@@ -38,6 +38,7 @@ struct TColumn {
14: optional i32 gram_size
15: optional i32 gram_bf_size
16: optional string aggregation
+ 17: optional bool result_is_nullable
Review Comment:
why not use the is allow null ? if add a new property add comment with the difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org