You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/05/19 22:32:40 UTC
[GitHub] [druid] imply-cheddar commented on pull request #12545: Planner test framework
imply-cheddar commented on PR #12545:
URL: https://github.com/apache/druid/pull/12545#issuecomment-1132267990
So great!
On the `.case` files, how do you feel about, instead of having it all be in one big, long, running file, each query be chunked into independent files? For example, the `arrayQueries.case`, would become a directory and under that directory you would have `select_constant.sql` for the query. `select_constant.planner` for the planner artifacts and `select_constant.results` for expected results?
This does create a proliferation of files and reading files can be slow, so it runs the risk of slowing down tests (though, presently, the tests are reindexing all of the test data on every single test, which is probably more work than loading files that specify queries and results and stuff), but it also separates things a bit. Especially when we want to bundle in result verification, putting the expected results into the big flowing file can make that file rather unweildy (especially if the expected result set is hundreds or thousands of lines long).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org