You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/05 14:58:45 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3685: NO-JIRA: make errorprone consistently opt-in on all JDKs
gemmellr opened a new pull request #3685:
URL: https://github.com/apache/activemq-artemis/pull/3685
The use of errorprone compiler plugin is opt-in on JDK8 and JDK16 already (due to the very slow compiler forking needed there) but is on by default in JDK11 etc with no easy way to disable it (still adds 2 minutes of build overhead running on Java 11 without forking). It would be good to make it consistently opt-in, making it easier to see the core build detail locally without it present (it emits a lot of added output) and not incurring the build overhead unless actually requested.
It will still always be run in CI as that always sets -Derrorprone when running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3685: NO-JIRA: make errorprone consistently opt-in on all JDKs
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3685:
URL: https://github.com/apache/activemq-artemis/pull/3685#issuecomment-893581822
I dont think you can, one profile cant enable another, and there are multiple different configs needed for errorprone depending on JDK so it needs to be in separate profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3685: NO-JIRA: make errorprone consistently opt-in on all JDKs
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3685:
URL: https://github.com/apache/activemq-artemis/pull/3685#issuecomment-893578809
@gemmellr would you know how to make -Pdev setting error prone by default?
I have tried doing it before and I couldn't figure it out...
In my Mind, if I compiled with -Pdev I would expect to have error prone by default.
(I'm simply asking here.. not asking you to do it of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3685: NO-JIRA: make errorprone consistently opt-in on all JDKs
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3685:
URL: https://github.com/apache/activemq-artemis/pull/3685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org