[GitHub] [flink-statefun] igalshilman commented on a change in pull request #47: [FLINK-16326] [core] Eagerly validate strictly required Flink configurations

[GitBox <gi...@apache.org>]

igalshilman commented on a change in pull request #47: [FLINK-16326] [core] Eagerly validate strictly required Flink configurations
URL: https://github.com/apache/flink-statefun/pull/47#discussion_r386980198
 
 

 ##########
 File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfig.java
 ##########
 @@ -243,4 +246,34 @@ public void addAllGlobalConfigurations(Map<String, String> globalConfigurations)
   public void setGlobalConfiguration(String key, String value) {
     this.globalConfigurations.put(key, value);
   }
+
+  private static void validateStrictlyRequiredConfigs(Configuration configuration) {
 
 Review comment:
   Can you extract the validation logic to a separate class?
   It can be an inner static class for now, or a separate class with validation specific logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services