You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Wenjing Huang (JIRA)" <ji...@apache.org> on 2009/12/22 02:20:18 UTC
[jira] Created: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
INKApi should expose the original Host header (as in the pristine header) to the plugins
----------------------------------------------------------------------------------------
Key: TS-96
URL: https://issues.apache.org/jira/browse/TS-96
Project: Traffic Server
Issue Type: New Feature
Components: InkAPI
Reporter: Wenjing Huang
Currently, its impossible to get the pristine host header from the INKHttp plugins.
This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
(copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Wenjing Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793749#action_12793749 ]
Wenjing Huang commented on TS-96:
---------------------------------
please see attachment for code diff
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wenjing Huang
> Attachments: code_diff.txt
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Wendy Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Huang updated TS-96:
--------------------------
Attachment: TS-96.patch
code patch
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Attachments: code_diff.txt, TS-96.patch
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803498#action_12803498 ]
Bryan Call commented on TS-96:
------------------------------
More comments:
1. Use URL instead of URLImpl * for pristine_url_impl
2. There is an easier way to perform a URL copy instead of getting into the guts: t_state.hdr_info.client_request.url_get() and URL::copy(url)
Side note:
URL and URLImpl should be combined and pimpl should not be used for classes that are *only used internally*. HTTPHdr uses a pimpl too and should be looked at. These are not real pimpls because the expose the impls as public members.
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Attachments: code_diff.txt
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-96.
-----------------------------
Resolution: Fixed
Committed to trunk.
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Fix For: 2.0.0a
>
> Attachments: code_diff.txt, TS-96.patch
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803454#action_12803454 ]
Leif Hedstrom commented on TS-96:
---------------------------------
I talked this over with Bryan, but I think we should use URL instead of URLImpl when possible (even though there is existing code doing the "wrong" thing).
Cheers,
-- leif
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Attachments: code_diff.txt
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TS-96) INKApi should expose the
original Host header (as in the pristine header) to the plugins
Posted by "Wendy Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806137#action_12806137 ]
Wendy Huang edited comment on TS-96 at 1/28/10 10:38 PM:
---------------------------------------------------------
code patch attached: TS-96.patch
was (Author: hwenjing):
code patch
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Attachments: code_diff.txt, TS-96.patch
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803440#action_12803440 ]
Bryan Call commented on TS-96:
------------------------------
I reviewed the patch and here are some comments:
1. have INKHttpTxnPristineUrlGet return a INKReturnCode and use the enums in the function (INK_ERROR & INK_SUCCESS)
2. use 2 space indentation instead of 4 space
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Attachments: code_diff.txt
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Wenjing Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wenjing Huang updated TS-96:
----------------------------
Attachment: code_diff.txt
code diff for review
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wenjing Huang
> Attachments: code_diff.txt
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-96) INKApi should expose the original Host
header (as in the pristine header) to the plugins
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-96:
----------------------------
Fix Version/s: 2.0.0a
> INKApi should expose the original Host header (as in the pristine header) to the plugins
> ----------------------------------------------------------------------------------------
>
> Key: TS-96
> URL: https://issues.apache.org/jira/browse/TS-96
> Project: Traffic Server
> Issue Type: New Feature
> Components: InkAPI
> Reporter: Wendy Huang
> Fix For: 2.0.0a
>
> Attachments: code_diff.txt, TS-96.patch
>
>
> Currently, its impossible to get the pristine host header from the INKHttp plugins.
> This is needed by both the stale-while-revalidate plugin and the INKHttpFetchPage APIs.
> (copied from bugzilla# 3203195)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.