[skywalking-banyandb] 01/01: Clean up invalid todos

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch clean-todo
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git

commit ffdce74ba264ab4e5a3d1fdd9e9860f653f0d133
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Tue Nov 8 09:35:51 2022 +0000

    Clean up invalid todos
    
    Signed-off-by: Gao Hongtao <ha...@gmail.com>
---
 banyand/metadata/schema/etcd.go     | 1 -
 banyand/tsdb/seriesdb.go            | 1 -
 pkg/query/logical/measure/schema.go | 5 -----
 pkg/query/logical/schema.go         | 1 -
 pkg/query/logical/stream/schema.go  | 5 -----
 5 files changed, 13 deletions(-)

diff --git a/banyand/metadata/schema/etcd.go b/banyand/metadata/schema/etcd.go
index 15f8eec..b640e21 100644
--- a/banyand/metadata/schema/etcd.go
+++ b/banyand/metadata/schema/etcd.go
@@ -355,7 +355,6 @@ func incrementLastByte(key string) string {
 func newStandaloneEtcdConfig(config *etcdSchemaRegistryConfig) *embed.Config {
 	cfg := embed.NewConfig()
 	cfg.LogLevel = config.loggerLevel
-	// TODO: allow user to set path
 	cfg.Dir = filepath.Join(config.rootDir, "metadata")
 	cURL, _ := url.Parse(config.listenerClientURL)
 	pURL, _ := url.Parse(config.listenerPeerURL)
diff --git a/banyand/tsdb/seriesdb.go b/banyand/tsdb/seriesdb.go
index b878b38..6c4ae55 100644
--- a/banyand/tsdb/seriesdb.go
+++ b/banyand/tsdb/seriesdb.go
@@ -252,7 +252,6 @@ func (s *seriesDB) List(path Path) (SeriesList, error) {
 }
 
 func (s *seriesDB) span(ctx context.Context, timeRange timestamp.TimeRange) ([]BlockDelegate, error) {
-	// TODO: return correct blocks
 	result := make([]BlockDelegate, 0)
 	for _, s := range s.segCtrl.span(timeRange) {
 		dd, err := s.blockController.span(ctx, timeRange)
diff --git a/pkg/query/logical/measure/schema.go b/pkg/query/logical/measure/schema.go
index 7dcf54d..a3e1ed6 100644
--- a/pkg/query/logical/measure/schema.go
+++ b/pkg/query/logical/measure/schema.go
@@ -117,8 +117,3 @@ func (m *schema) registerField(fieldIdx int, spec *databasev1.FieldSpec) {
 		Spec:     spec,
 	}
 }
-
-func (m *schema) TraceIDFieldName() string {
-	// We don't have traceID for measure
-	panic("implement me")
-}
diff --git a/pkg/query/logical/schema.go b/pkg/query/logical/schema.go
index a37b08b..29e7c88 100644
--- a/pkg/query/logical/schema.go
+++ b/pkg/query/logical/schema.go
@@ -36,7 +36,6 @@ type Schema interface {
 	ProjFields(refs ...*FieldRef) Schema
 	Equal(Schema) bool
 	ShardNumber() uint32
-	TraceIDFieldName() string
 }
 
 type TagSpec struct {
diff --git a/pkg/query/logical/stream/schema.go b/pkg/query/logical/stream/schema.go
index 805568a..fa5bce3 100644
--- a/pkg/query/logical/stream/schema.go
+++ b/pkg/query/logical/stream/schema.go
@@ -44,11 +44,6 @@ func (s *schema) EntityList() []string {
 	return s.common.EntityList
 }
 
-func (s *schema) TraceIDFieldName() string {
-	// TODO: how to extract trace_id?
-	return "trace_id"
-}
-
 // IndexDefined checks whether the field given is indexed
 func (s *schema) IndexDefined(tagName string) (bool, *databasev1.IndexRule) {
 	return s.common.IndexDefined(tagName)